Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algernon instances used in tests aren't properly disposed #245

Closed
gwauge opened this issue May 14, 2022 · 0 comments · Fixed by #253
Closed

Algernon instances used in tests aren't properly disposed #245

gwauge opened this issue May 14, 2022 · 0 comments · Fixed by #253

Comments

@gwauge
Copy link
Contributor

gwauge commented May 14, 2022

User story

As an Algernon dev, I would like to run tests without breaking my working version of Algernon, in order to speed up development time.

Issue

when one runs Algernons test suite (or selected UI tests), these tests apparently open up new Algernon instances to perform their assertions. However it seems they do not properly dispose of the Algernon instance. This results in mutiple Algernon windows being overlayed on top of each other which can only be closed by pressing the close key (i.e. esc) dozens of times or holding it for an extende period of time.
This isn't an issue for CI runs, since the CI image gets deleted. It is however very annoying in the development process.

Reproduction

  • run some or all test cases, that include UI assertions
  • open Algernon as usual
  • observer the background being opaque white, instead of partially transparent
  • try closing Algernon

Proposed fix

  • global teardown (if possible) that closes all the instance
  • shouldn't close the actual instance on the system

Temporary workaround

  • run ALGCore allInstances do: [:item | item delete] in your workspace to close all instances
  • open up Preferences >> Algernon and re-enable it
  • back to normal!
@gwauge gwauge changed the title Algernon instances used in test aren't properly removed Algernon instances used in tests aren't properly removed May 14, 2022
@gwauge gwauge changed the title Algernon instances used in tests aren't properly removed Algernon instances used in tests aren't properly disposed May 14, 2022
FSadrieh pushed a commit that referenced this issue May 30, 2022
gwauge added a commit that referenced this issue Jun 8, 2022
* Fix: Remove algernon instances after tests are finished.

- Resolves #245

Co-authored-by: Georg Auge <[email protected]>

* Fix: Algernon not activated after running tests

Co-authored-by: Frederic Sadrieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants