Resolved validation issue on set temperature point method.#3
Merged
Conversation
hpeyerl
approved these changes
Jan 14, 2018
Owner
|
ok. done. 0.3 is pushed to pypi. |
Contributor
Author
|
great thanks! home-assistant/core#11639 |
Owner
|
Good luck. I dropped the ball on one I did earlier in the year: Never got back to it. |
Contributor
Author
|
Thanks- yeah I usually go through a few iterations. Usually it’s because the internals of hass are constantly undergoing improvements, and so when I rarely submit something, I’m not usually following those latest standards. Well see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry- I was doing last minute testing prior to doing my pull request for hass, and ran into this issue. Looking closely at the API- this check only applies if you're running the system in "auto" mode- not if in heat/cool mode. So i adjusted this validation. Can we do a 0.3 so i can push the hass component?