Component/Switch/Sensor for QuickSmart Etherrain/8 network irrigation by hpeyerl · Pull Request #8900 · home-assistant/core

hpeyerl · 2017-08-09T13:51:33Z

Description:

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3155

Example entry for `configuration.yaml` (if applicable):

etherrain:
  host: 192.168.1.1
  username: admin
  password: pw
switch:
  - platform: etherrain
    valve_id: 1
    name: "Side Beds"
    duration: 20
sensor:
  -platform: etherrain
    valve_id: 1
    name: "Side Beds"

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

The etherrain/8 will only take commands from the last IP that logged in to it. So if a different host on the network is also issuing commands to the ER/8, then our commands will fail. There is obviously a bit of a race condition here. This at least somewhat mitigates the problem.

homeassistant · 2017-08-09T13:51:35Z

Hello @hpeyerl,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

16ffe8f5e1a3a019f355eed6ff7464d94b5f4d31 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
86494a18263bb5e01d5ae8721d962f3a8b11b8ca - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
79b692cee00ba9e7977ff09d861a8bed40294a2c - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
ff7d1335475dea2c6465a9346b7f55fed9e20db0 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
3839efc18647537cdeff57f4ea73b1aa3ef51194 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
78b8ebd935d79f4e79e3717cb720271b622b36a7 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
60a5e36a0ceccc2d691d667336795f13a5e3b274 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
54380599bb8e200bea9ab19e33fe426dffd97414 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
866f0463f43e1cfa59ac1042b712c4584dc89637 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
c838277ceafdb89074afe92a78db34c6d2ebc8c4 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
c5b453c31b0dda4768fcce757b365d717d9ba709 - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.
d3006b67a28ade33bcb9d5783d0af59672cfef7c - This commit has something that looks like an email address (hpeyerl+gitlab@beer.org). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

houndci-bot · 2017-08-09T13:51:41Z

+
+    def turn_off(self):
+        """Turn a valve off."""
+        # We should first check the state and if it's "BZ" and the valve_id matches,


line too long (84 > 79 characters)

homeassistant · 2017-08-09T14:01:08Z

Hi @hpeyerl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

fabaff · 2017-08-20T21:07:28Z

@@ -0,0 +1,172 @@
+""".


Please remove the dot.

fabaff · 2017-08-20T21:08:12Z

+
+Support for Etherrain/8.
+
+"""


Please follow the file header style of the other files.

fabaff · 2017-08-20T21:11:23Z

+    ER = {}
+
+    conf = config[DOMAIN]
+    schema = 'http'


Looks superfluous as there is only support for http.

fabaff · 2017-08-20T21:11:28Z

+
+def setup(hass, config):
+    """Set up the Etherrain component."""
+    global ER


Don't use global, use hass.data[] directly.

fabaff · 2017-08-20T21:12:10Z

+    # ergetcfg.cgi?lu=admin\&lp=deadbeef
+    url = '{0}/ergetcfg.cgi?lu={1}&lp={2}'.format(
+        ER['server_origin'], ER['username'], ER['password'])
+    req = requests.get(url, timeout=DEFAULT_TIMEOUT)


Add a timeout to all requests.

fabaff · 2017-08-20T21:14:14Z

+def setup_platform(hass, config, add_devices, discovery_info=None):
+    """Set up the Etherrain irrigation platform."""
+    valve_id = config.get("valve_id")
+    valve_name = config.get("name")


Must go through the configuration validation as optional.

fabaff · 2017-08-20T21:14:18Z

+    """Set up the Etherrain irrigation platform."""
+    valve_id = config.get("valve_id")
+    valve_name = config.get("name")
+    duration = config.get("duration")


fabaff · 2017-08-20T21:21:45Z

+
+
+# pylint: disable=no-member
+def login():


Move the communication with the EtherRain API to a Python module, publish it on PyPI, and make it a requirement.

balloob · 2017-09-30T18:21:40Z

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.

hpeyerl · 2017-10-01T11:44:47Z

Yes. Life got in the way. I've got the above changes made on my own branch and working but have not gone through enough integration testing to resubmit. Now irrigation season is over so maybe next year.

hpeyerl added 12 commits July 16, 2017 08:15

initial translation of zoneminder module into etherrain module

d3006b6

Switch code for Etherrain/8 component

c5b453c

Clean up some extraneous logging

c838277

port over a zoneminder sensor to etherrain

866f046

remove redundant comment

5438059

pass flake8

60a5e36

pass flake8

78b8ebd

pass flake8/pylint/pydoctstyle

3839efc

etherrain has no tests

79b692c

remove command_on/command_off. Change icon

86494a1

allow duration to be overridden in config

16ffe8f

homeassistant added cla-error new-platform integration: etherrain platform: sensor.etherrain labels Aug 9, 2017

balloobbot added component platform labels Aug 9, 2017

houndci-bot reviewed Aug 9, 2017

View reviewed changes

line too long fix...

eb4bbe5

homeassistant added cla-needed cla-signed and removed cla-needed labels Aug 9, 2017

EtherRain sensor is redundant.

e26e496

homeassistant added the cla-signed label Aug 10, 2017

Landrash mentioned this pull request Aug 10, 2017

Component/Switch/Sensor for QuickSmart Etherrain/8 network irrigation… home-assistant/home-assistant.io#3155

Closed

disable some more logging

783974a

fabaff requested changes Aug 20, 2017

View reviewed changes

robbiet480 removed the cla-error label Aug 21, 2017

balloob closed this Sep 30, 2017

hpeyerl mentioned this pull request Jan 14, 2018

Resolved validation issue on set temperature point method. hpeyerl/venstar_colortouch#3

Merged

home-assistant locked and limited conversation to collaborators Mar 3, 2018

ghost removed platform: sensor.etherrain labels Mar 21, 2019


		Support for Etherrain/8.

		"""

Uh oh!

Conversation

hpeyerl commented Aug 9, 2017

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Aug 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

homeassistant commented Aug 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob commented Sep 30, 2017

Uh oh!

hpeyerl commented Oct 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Example entry for `configuration.yaml` (if applicable):