[feature] Use PrefixConfiguration in converters #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patochectp
approved these changes
Jul 22, 2020
woshilapin
force-pushed
the
prefix-configuration
branch
from
970177e to
4d6d17b
Compare
datanel
approved these changes
Jul 23, 2020
woshilapin
force-pushed
the
prefix-configuration
branch
2 times, most recently
from
55661eb to
46073ce
Compare
|
I rebased this PR after #678 has been merged. Fixtures for |
This comment has been minimized.
This comment has been minimized.
woshilapin
force-pushed
the
prefix-configuration
branch
from
46073ce to
7a60d82
Compare
Done. Thanks for pinging me on that topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠️ This PR must be merged after #675 ⚠️ Only the last commit needs to be review, the two other commits are part of #675.PR has been rebased.transit_model.ref: ND-963