Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] AddPrefix can prefix referential or scheduled objects #675

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

woshilapin
Copy link
Contributor

Evolution of the AddPrefix trait in order to be able to prefix with more information. This evolution is needed for merging together objects of the same contributors that might have the same identifier but are different objects from transit_model point-of-view (for example, a VehicleJourney that would share the same identifier for the winter service and the summer service).

ref: ND-964

@ArnaudOggy ArnaudOggy marked this pull request as draft July 21, 2020 11:44
@ArnaudOggy ArnaudOggy marked this pull request as ready for review July 21, 2020 13:11
@woshilapin
Copy link
Contributor Author

I'm gonna try to add a test that combine a config.json and a prefix in the converter gtfs2ntfs.

@ArnaudOggy
Copy link
Contributor

I'm gonna try to add a test that combine a config.json and a prefix in the converter gtfs2ntfs.

In #677 😉

@woshilapin woshilapin closed this Jul 22, 2020
@woshilapin woshilapin reopened this Jul 22, 2020
@woshilapin
Copy link
Contributor Author

Small fix concerning the case when dataset identifiers are smaller than 6 characters. See 7c29b7e.

@woshilapin woshilapin merged commit ff3a2fe into hove-io:master Jul 23, 2020
@woshilapin woshilapin deleted the add_prefix branch July 23, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants