[feature] Add 'trip_short_name' into 'trips.txt' (NTFS v0.10.0) #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
commented
Nov 8, 2019
| French](https://github.com/CanalTP/ntfs-specification/blob/master/ntfs_changelog_fr.md)). | ||
| From the standard, some of the functionalities are not fully supported: | ||
| - Management of pathways introduced in version `v0.8` is not supported | ||
| - No support for all periodic description (files `grid_calendars.txt`, |
woshilapin
force-pushed
the
trip_short_name
branch
from
148897a to
2b13195
Compare
woshilapin
commented
Nov 8, 2019
| French](https://github.com/CanalTP/ntfs-specification/blob/master/ntfs_changelog_fr.md)). | ||
| From the standard, some of the functionalities are not fully supported: | ||
| - Management of pathways introduced in version `v0.8` is not supported |
There was a problem hiding this comment.
This can be removed since it has been done in #398.
datanel
reviewed
Nov 8, 2019
Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| authors = ["Kisio Digital <[email protected]>", "Guillaume Pinot <[email protected]>"] | |||
| name = "transit_model" | |||
| version = "0.10.0" | |||
| version = "0.11.0" | |||
There was a problem hiding this comment.
I don't think it's a good idea. If this PR is merged, in the next PR I can also put 0.12.0 and deploys whereas 0.10.0 has never been deployed.
There was a problem hiding this comment.
No, you wouldn't put 0.12.0 because you would check first what is the last released version. The idea is not to increment it everytime you do change something, the idea is just to verify that is coherent with 2 information:
- what is the last released version
- what kind of change my PR is doing, and keep or change the next version accordingly
Yes, we need to populate the |
datanel
previously approved these changes
Nov 13, 2019
woshilapin
force-pushed
the
trip_short_name
branch
from
2b13195 to
9dff77d
Compare
mergify
bot
dismissed
datanel’s stale review
Pull request has been modified.
woshilapin
force-pushed
the
trip_short_name
branch
from
9dff77d to
b87dbb0
Compare
datanel
approved these changes
Nov 14, 2019
ArnaudOggy
approved these changes
Nov 14, 2019
datanel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I'm bumping version of
transit_modelto0.11.0since this is a breaking change.