update GTFS parser according to the specifications #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
previously requested changes
Oct 4, 2019
src/utils.rs
Outdated
| @@ -69,6 +69,25 @@ where | |||
| Ok(i != 0) | |||
| } | |||
|
|
|||
| pub fn de_from_u8_with_check<'de, D>(deserializer: D) -> Result<bool, D::Error> | |||
There was a problem hiding this comment.
Why creating a new function? The function just above is doing exactly the same. You could improve the function just above?
There was a problem hiding this comment.
I created this PR to solve the problem.
patochectp#3
|
There is a function |
mergify
bot
dismissed
woshilapin’s stale review
Pull request has been modified.
patochectp
force-pushed
the
update_gtfs_parser
branch
from
57ae67d to
562b630
Compare
datanel
reviewed
Oct 7, 2019
src/gtfs/read.rs
Outdated
| @@ -87,44 +87,170 @@ impl From<Stop> for objects::StopArea { | |||
| if let Some(c) = stop.code { | |||
| stop_codes.insert(("gtfs_stop_code".to_string(), c)); | |||
| } | |||
| let coord: Coord = Coord::from((stop.lon, stop.lat)); | |||
There was a problem hiding this comment.
or
let coord: Coord = (stop.lon, stop.lat).into();
ArnaudOggy
reviewed
Oct 7, 2019
| stop:31,pouet,48.844746,2.372987,0,stoparea:1 | ||
| stop:32,pouet,48.844746,2.372987,0,stoparea:1 | ||
| stop:33,pouet,48.844746,2.372987,0,stoparea:1 | ||
| stop_id,stop_name,stop_lat,stop_lon,location_type,parent_station,level_id |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
patochectp
force-pushed
the
update_gtfs_parser
branch
from
76c2dae to
a75cb17
Compare
Add prefix to Frequency
Add 'gtfs_stop_code' in the specification
Add 'source' object code for 'stop_point'
Force a boolean to be 0 or 1 in deserialization
woshilapin
previously approved these changes
Oct 15, 2019
Manage pathways refactoring
woshilapin
approved these changes
Oct 15, 2019
ArnaudOggy
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.