Test windows #356
Merged
Test windows #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can safely assume that the application can be build when the test suite succeeds.
Tests will fail if the unmmap error is returned instead of being logged (FIXME annotation).
blobbered
force-pushed
the
test-windows
branch
from
69f21ce to
04dc6e8
Compare
blobbered
force-pushed
the
test-windows
branch
7 times, most recently
from
b958cc0 to
e8cf816
Compare
blobbered
force-pushed
the
test-windows
branch
from
e8cf816 to
632a742
Compare
|
Hi @blobbered |
dschott68
reviewed
Dec 22, 2020
.github/workflows/go.yaml
Outdated
| @@ -19,14 +19,28 @@ jobs: | |||
| with: | |||
| node-version: "10.x" | |||
| - run: npm install | |||
| go-test: | |||
| lint: | |||
There was a problem hiding this comment.
Since lint is only for ubuntu and not windows, did you want it in this PR or did you want to split it off into separate smaller PR?
dschott68
reviewed
Dec 22, 2020
codesearch/index/write.go
Outdated
| @@ -563,15 +563,16 @@ func (b *bufWriter) offset() uint32 { | |||
| return uint32(off) | |||
| } | |||
|
|
|||
| func (b *bufWriter) flush() { | |||
| func (b *bufWriter) flush() error { | |||
There was a problem hiding this comment.
Should we care that the other callers of flush() besides Flush() are not handling the returned error?
dschott68
approved these changes
Jan 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of several smaller ones made from this original PR, by klingtnet.
This PR is responsible for cleaning up the go build and test so that they run on windows.