Maintenance #341
Maintenance #341
Conversation
`go mod init github.com/hound-search/hound`
Replaces Travis CI with Github Actions for better integration. Jobs are run against more recent Go versions, namely 1.12 to 1.14 . . For further documentation see - https://github.com/actions/setup-go - and https://help.github.com/en/actions This adds `-race` flag to the Go tests and will run a meta linter (golangci-lint).
We can use relative paths since this is a Modules project now.
We can safely assume that the application can be build when the test suite succeeds.
The former package is unmainatained since a while and the replacement also fixes this bug I encountered when trying to build the package: jteeuwen/discussions#6
Tests will fail if the unmmap error is returned instead of being logged (FIXME annotation).
|
Nevermind, I implemented my own code search in the mean time (which will hopefully be open sourced as well). |
|
Hey, we appreciate this contribution. We're still trying to triage some of the issues in the backlog. It's very hard to review all these pull requests, particularly when we are still ramping up on our understanding of the codebase, and when the PRs are especially large (like this one). I'd be happy to merge your work, but I'd ask that you be patient with us as well. If you want to make things a bit easier on our end, I'd love to see each of the features in this PR broken up into separate PRs (linting, Github Actions, the Go runtime upgrade, the migration to Go modules, and the enforcement of a linter). |
Thank you for the quick reply, I am happy to see that the project is not abandoned, which I thought it is previously. However, I do not know when I find the time for splitting up or adjusting the changes. If anyone else want's to grab a part, e.g. adding Go modules support, feel free to do so. |
|
That makes sense. For some context, I'm one of a handful of engineers that have volunteered to maintain the project as of this summer: We are definitely interested in making sure Hound is super stable so that adopting future contributions would be easier, so at the very least this PR goes a long way towards helping us carve out some work. |
This pull request does a bit of project maintenance:
CI Improvements
Project improvements
go-bindatadependency is updated and replaced by a maintained fork¹
unmmapfails in thewriteunit tests if the error is propagated. Not sure if this is a problem outside the test environment. Fixing this is outside the scope of this PR.