Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(request): show user-friendly type for c.req.param() #2780

Merged
merged 3 commits into from
May 24, 2024
+2 −2
Merged

refactor(request): show user-friendly type for c.req.param() #2780

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52a9f1f
refactor(request): show user-friendly type for `c.req.param()`
usualoma May 24, 2024
79357f6
chore: denoify
usualoma May 24, 2024
b934b46
Merge branch 'next' into feat-user-friendly-param-type
usualoma May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type {
} from './types'
import { parseBody } from './utils/body'
import type { BodyData, ParseBodyOptions } from './utils/body'
import type { UnionToIntersection } from './utils/types'
import type { Simplify, UnionToIntersection } from './utils/types'
import { getQueryParam, getQueryParams, decodeURIComponent_ } from './utils/url'

type Body = {
Expand Down Expand Up @@ -80,7 +80,7 @@ export class HonoRequest<P extends string = '/', I extends Input['out'] = {}> {
key: P2
): string | undefined
param(key: string): string | undefined
param<P2 extends string = P>(): UnionToIntersection<ParamKeyToRecord<ParamKeys<P2>>>
param<P2 extends string = P>(): Simplify<UnionToIntersection<ParamKeyToRecord<ParamKeys<P2>>>>
param(key?: string): unknown {
return key ? this.getDecodedParam(key) : this.getAllDecodedParams()
}
Expand Down