Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(request): show user-friendly type for c.req.param() #2780

Merged
merged 3 commits into from
May 24, 2024

Conversation

usualoma
Copy link
Member

Before

CleanShot 2024-05-24 at 17 46 31@2x

After

CleanShot 2024-05-24 at 17 46 49@2x

The author should do the following, if applicable

  • Add tests
    • The tests we have now are sufficient.
  • Run tests
  • bun denoify to generate files for Deno
  • bun run format:fix && bun run lint:fix to format the code

@usualoma
Copy link
Member Author

@yusukebe How about this?

@yusukebe
Copy link
Member

@usualoma

Looks good to me!

Let's merge. But right now, shall we merge it into the next?

@yusukebe yusukebe changed the base branch from main to next May 24, 2024 09:29
@usualoma
Copy link
Member Author

@yusukebe Understood!
Merged next into this branch.

@yusukebe
Copy link
Member

@usualoma

Yeah. denoify is no longer needed! Merging.

@yusukebe yusukebe merged commit d5e7da3 into honojs:next May 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants