Skip to content

Add a keypress service for AlarmDecoder#26100

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
jkeljo:alarmdecoder_keypress
Sep 1, 2019
Merged

Add a keypress service for AlarmDecoder#26100
MartinHjelmare merged 3 commits into
home-assistant:devfrom
jkeljo:alarmdecoder_keypress

Conversation

@jkeljo
Copy link
Copy Markdown
Contributor

@jkeljo jkeljo commented Aug 21, 2019

Description:

This allows automations to send arbitrary keypresses to the alarm panel, which opens up possibilities ranging from arming in modes not supported by the general component (like "instant" or "max"), to performing complex programming tasks.

The Envisalink component already had such a service. This one sticks to its naming and schema as much as possible, though to my knowledge there is no character limit on the keypresses you can send to the panel.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10195

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/alarm_control_panel/services.yaml Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
Comment thread homeassistant/components/alarmdecoder/alarm_control_panel.py Outdated
@MartinHjelmare MartinHjelmare changed the title Add a keypress service for AlarmDecoder (like Envisalink has) Add a keypress service for AlarmDecoder Aug 31, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 5ba436e into home-assistant:dev Sep 1, 2019
pgilad added a commit to pgilad/home-assistant that referenced this pull request Sep 1, 2019
…into improve-bluetooth-tracker

* 'dev' of https://github.com/home-assistant/home-assistant: (229 commits)
  New template sensor attributes (home-assistant#26127)
  Add BeeWi SmartClim BLE sensors (home-assistant#26174)
  UniFi - Simplify getting controller from config entry (home-assistant#26335)
  Inverted rflink cover (home-assistant#26038)
  Upgrade tibber library (home-assistant#26332)
  Migrate Axis, deCONZ and UniFi to use config entry subclass (home-assistant#26173)
  Upgrade sqlalchemy to 1.3.8 (home-assistant#26331)
  Change evohome to asyncio client (home-assistant#26042)
  Add support for Supla switches (home-assistant#26188)
  Add a keypress service for AlarmDecoder (home-assistant#26100)
  Fix google_maps scan interval (home-assistant#26328)
  Upgrade youtube_dl to 2019.09.01 (home-assistant#26330)
  Fix onvif camera setup error (home-assistant#24585)
  UniFi - use entity registry disabled_by to control available entities  (home-assistant#26141)
  Fetch Onkyo current radio preset (home-assistant#26211)
  Add precision argument to the Range Filter (home-assistant#25874)
  Fix alexa bad temp sensors (home-assistant#26307)
  deCONZ - Dont update entry if data is equal
  Add Withings support (home-assistant#25154)
  Add support for Homekit accessory battery sensors (home-assistant#26210)
  ...
@lock lock Bot locked and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants