Add more configuration options for the Harman Kardon AVR component#23569
Closed
Devqon wants to merge 6 commits intohome-assistant:devfrom
Closed
Add more configuration options for the Harman Kardon AVR component#23569Devqon wants to merge 6 commits intohome-assistant:devfrom
Devqon wants to merge 6 commits intohome-assistant:devfrom
Conversation
2 tasks
Codecov Report
@@ Coverage Diff @@
## dev #23569 +/- ##
==========================================
+ Coverage 93.83% 94.2% +0.36%
==========================================
Files 462 453 -9
Lines 37686 36913 -773
==========================================
- Hits 35363 34773 -590
+ Misses 2323 2140 -183
Continue to review full report at Codecov.
|
balloob
reviewed
Jun 19, 2019
| def source_list(self): | ||
| """Available sources.""" | ||
| return self._source_list | ||
| return self._sources |
Member
There was a problem hiding this comment.
We should not allow overriding the sources via the config. What is wrong with the options that come from the API?
balloob
reviewed
Jun 19, 2019
| @property | ||
| def supported_features(self): | ||
| """Flag media player features that are supported.""" | ||
| if self._simulate_volume_set: |
balloob
reviewed
Jun 19, 2019
| name = config[CONF_NAME] | ||
| host = config[CONF_HOST] | ||
| port = config[CONF_PORT] | ||
| key_interval = config[CONF_KEY_INTERVAL] |
Member
There was a problem hiding this comment.
I don't see a use for this either, and it's only used for the fake volume? We should drop it.
Member
|
I don't think that each of the three features this PR aims to add belong in Home Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This allows the user to:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9254
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
Note: There was a previous pull request, but I cannot re-open it: #23162