Skip to content

Fix for Neato D3 and D5#11775

Merged
fabaff merged 1 commit into
home-assistant:devfrom
karlkar:neato
Jan 18, 2018
Merged

Fix for Neato D3 and D5#11775
fabaff merged 1 commit into
home-assistant:devfrom
karlkar:neato

Conversation

@karlkar
Copy link
Copy Markdown
Contributor

@karlkar karlkar commented Jan 18, 2018

Description:

Neato D3 and D5 vacuums currently doesn't support start/pause/resume actions.
In a matter of fact they could support it, we're just using it in a wrong version. Changes made to pybotvac by @kvermilion allowed him to control his Botvac D5. Changes were made with my review, as a user of D3. @jabesq who is an owner of pybotvac repository has Botvac. So all 3 robots are covered and they work fine. Let's update!

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4456

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit cf6f916 into home-assistant:dev Jan 18, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
fabaff pushed a commit to home-assistant/home-assistant.io that referenced this pull request May 20, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants