Fix for Neato D3 and D5#4456
Merged
Merged
Conversation
9 tasks
Member
|
Can you please clean-up your PR? It should don't your changes. |
Contributor
Author
|
I had chosen wrong base by mistake. Now it is fine. |
Member
|
@fabaff You merged this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Neato D3 and D5 vacuums currently doesn't support start/pause/resume actions.
In a matter of fact they could support it, we're just using it in a wrong version. Changes made to pybotvac by @kvermilion allowed him to control his Botvac D5. Changes were made with my review, as a user of D3. @jabesq who is an owner of pybotvac repository has Botvac. So all 3 robots are covered and they work fine. Let's update!
Pull request in home-assistant (if applicable): home-assistant/core#11775
Checklist:
current. New documentation for platforms/components and features should go tonext.