Skip to content

Adds support for additional Neato Botvac Connected devices.#11150

Closed
ghost wants to merge 1 commit into
devfrom
unknown repository
Closed

Adds support for additional Neato Botvac Connected devices.#11150
ghost wants to merge 1 commit into
devfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 15, 2017

Description:

Support for additional versions of Neato Botvac Connected devices was added to the stianaske/pybotvac repo and merged into jabesq's fork. This updates the version requirement found in the neato component to support the recent change.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @hoffmanpm2,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Dec 20, 2017

Please check the PR template:

  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@jpjodoin
Copy link
Copy Markdown
Contributor

@hoffmanpm2 : Are you still interested in completing this PR ? If not, I might send my own as I have a Neato Botvac Connected D5 I want to see in home-assistant. Thanks.

@jpjodoin
Copy link
Copy Markdown
Contributor

This can be closed as it has already been fixed by PR #11775

@rytilahti
Copy link
Copy Markdown
Member

Closing it then, thanks!

@rytilahti rytilahti closed this Feb 3, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants