Skip to content

Hue sensor support#9084

Merged
klaasnicolaas merged 3 commits into
home-assistant:nextfrom
mitchellrj:hue-sensors
Apr 28, 2019
Merged

Hue sensor support#9084
klaasnicolaas merged 3 commits into
home-assistant:nextfrom
mitchellrj:hue-sensors

Conversation

@mitchellrj
Copy link
Copy Markdown
Contributor

@mitchellrj mitchellrj commented Mar 31, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/core#22598

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Mar 31, 2019
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Apr 1, 2019
Comment thread source/_components/stream.markdown Outdated
@klaasnicolaas klaasnicolaas added the parent-merged The parent PR has been merged already label Apr 18, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

⚠️ Is it true that the changes to the stream component do not belong to this PR?

@mitchellrj
Copy link
Copy Markdown
Contributor Author

Fixed sorry. You're right, a commit for another branch accidentally made its way into this PR.

Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can merge it, after these suggested change 😉

Comment thread source/_components/hue.markdown Outdated
@klaasnicolaas klaasnicolaas removed the ready-for-review This PR needs to be reviewed label Apr 22, 2019
@rohankapoorcom
Copy link
Copy Markdown
Member

I think we need to pull this into current rather than next since this functionality was released in 0.92.

@mitchellrj mitchellrj changed the base branch from next to current April 27, 2019 07:03
@klaasnicolaas klaasnicolaas changed the base branch from current to next April 27, 2019 07:38
@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Apr 27, 2019

Adjusting the base branch does not work. Because of this we get unrelated commits that go along with the merge. It is better to merge it in next and then perform a cherry pick to the current branch or you must perform a rebase to current yourself

Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klaasnicolaas klaasnicolaas merged commit 131a1ff into home-assistant:next Apr 28, 2019
klaasnicolaas pushed a commit that referenced this pull request Apr 28, 2019
* Stub documentation for Hue sensor support.

* Configuration option was removed.

* ✏️ Tweak
rohankapoorcom pushed a commit that referenced this pull request Apr 28, 2019
* Stub documentation for Hue sensor support.

* Configuration option was removed.

* ✏️ Tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants