Skip to content

Update tap/hold actions to objects#7751

Merged
balloob merged 3 commits intohome-assistant:nextfrom
iantrich:tap-actions
Dec 12, 2018
Merged

Update tap/hold actions to objects#7751
balloob merged 3 commits intohome-assistant:nextfrom
iantrich:tap-actions

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Dec 6, 2018

home-assistant/frontend#2182
home-assistant/frontend#2186
home-assistant/frontend#2187

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost assigned iantrich Dec 6, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Dec 6, 2018
@iantrich iantrich requested a review from zsarnett December 6, 2018 05:26
Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions to fix the build error, they are all the same 😋

Comment thread source/_lovelace/entity-button.markdown Outdated
Comment thread source/_lovelace/entity-button.markdown Outdated
Comment thread source/_lovelace/glance.markdown Outdated
Comment thread source/_lovelace/glance.markdown Outdated
Comment thread source/_lovelace/picture-elements.markdown Outdated
Comment thread source/_lovelace/picture-entity.markdown Outdated
Comment thread source/_lovelace/picture-elements.markdown Outdated
Comment thread source/_lovelace/picture-elements.markdown Outdated
Comment thread source/_lovelace/picture-elements.markdown Outdated
Comment thread source/_lovelace/picture-elements.markdown Outdated
@balloob balloob added this to the 0.84 milestone Dec 10, 2018
@balloob balloob merged commit 083f7c0 into home-assistant:next Dec 12, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Dec 12, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 12, 2018

oops it was broken.

@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Dec 12, 2018
balloob pushed a commit that referenced this pull request Dec 12, 2018
* Update tap/hold actions to objects

* Update default action

* typo
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants