Closed
Conversation
ghost
assigned
balloob
reviewed
Dec 6, 2018
Member
So wise. |
balloob
reviewed
Dec 6, 2018
Member
|
Can you include some description what this PR does? |
iantrich
force-pushed
the
consolidate-button
branch
from
b253cce to
bb4d849
Compare
Member
Author
|
Done testing. Side note, after this gets merged, need to go and update the tap/hold gallery demos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
service-buttonelement to abuttonelement, with all the same functionality as theentity-buttoncard. Theentity-buttoncard has been renamed tobuttoncard and just wraps thebuttonelement now as the setting of anentityis now optional.If accepted, I plan on updating my outstanding documentation PR related to tap/hold actions: home-assistant/home-assistant.io#7751
home-assistant/ui-schema#211