Skip to content

Update Ruter docs#7623

Merged
ludeeus merged 2 commits intohome-assistant:nextfrom
tjorim:patch-9
Nov 25, 2018
Merged

Update Ruter docs#7623
ludeeus merged 2 commits intohome-assistant:nextfrom
tjorim:patch-9

Conversation

@tjorim
Copy link
Copy Markdown
Contributor

@tjorim tjorim commented Nov 24, 2018

Description:
Default name was missing and offset is 1 by default.

Since this was introduced in 0.83 (currently beta) I believe this PR should get milestone 0.83 as docs for a new component.

Pull request in home-assistant (if applicable): home-assistant/core#18678

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

Default name was missing and offset is 1 by default.
@ghost ghost added the to-do label Nov 24, 2018
@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Nov 24, 2018

I think the offset value is a "bug" in the code, and that is should have been 0, will test this.

@tjorim
Copy link
Copy Markdown
Contributor Author

tjorim commented Nov 24, 2018

Then we should either change the behaviour in the code or clarify how the offset value works. (Is it in minutes? Does it only show departures more than x minutes from now?)

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Nov 24, 2018

Its the placement in the dict returned from the API.
So a offset of 0 should give you next departure, 1 should be the one after that

Example:

0: 15:56
1: 16:04
2: 16:11

Setting up a dev env now to see if confirm that I screwed up..

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Nov 24, 2018

@tjorim Made a PR to set default value to 0 home-assistant/core#18678

@ludeeus ludeeus merged commit 55e4d59 into home-assistant:next Nov 25, 2018
@ghost ghost removed the to-do label Nov 25, 2018
@tjorim tjorim deleted the patch-9 branch November 25, 2018 11:54
@frenck frenck added bug This issue or PR is related to an unexpected behavoir on our website/documentation next This PR goes into the next branch labels Nov 25, 2018
@frenck frenck modified the milestones: 0.82, 0.83 Nov 25, 2018
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or PR is related to an unexpected behavoir on our website/documentation cherry-picked This PR has been manually picked and merged into the current branch next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants