Update Ruter docs#7623
Merged
ludeeus merged 2 commits intohome-assistant:nextfrom Nov 25, 2018
tjorim:patch-9
Merged
Conversation
Default name was missing and offset is 1 by default.
Member
|
I think the offset value is a "bug" in the code, and that is should have been |
Contributor
Author
|
Then we should either change the behaviour in the code or clarify how the offset value works. (Is it in minutes? Does it only show departures more than x minutes from now?) |
Member
|
Its the placement in the dict returned from the API. Example: Setting up a dev env now to |
Member
|
@tjorim Made a PR to set default value to |
ludeeus
approved these changes
Nov 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Default name was missing and offset is 1 by default.
Since this was introduced in 0.83 (currently beta) I believe this PR should get milestone 0.83 as docs for a new component.
Pull request in home-assistant (if applicable): home-assistant/core#18678
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.