Skip to content

Set correct default offset for ruter sensor#18678

Merged
fabaff merged 1 commit intohome-assistant:devfrom
ludeeus:ruter-offset
Nov 25, 2018
Merged

Set correct default offset for ruter sensor#18678
fabaff merged 1 commit intohome-assistant:devfrom
ludeeus:ruter-offset

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Nov 24, 2018 •
edited
Loading

Description:

Changes default offset to 0 (First departure)

Since this was introduced in 0.83 (currently beta) I believe this should go in as a beta fix.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: ruter
    stop_id: 123456

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned ludeeus Nov 24, 2018
@ghost ghost added the in progress label Nov 24, 2018
@ludeeus ludeeus mentioned this pull request Nov 24, 2018
Merged
2 tasks
@fabaff fabaff changed the base branch from dev to rc November 25, 2018 11:25
@fabaff fabaff changed the base branch from rc to dev November 25, 2018 11:25
@fabaff fabaff added this to the 0.83 milestone Nov 25, 2018
fabaff
fabaff approved these changes Nov 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@fabaff fabaff merged commit 23f5d78 into home-assistant:dev Nov 25, 2018
@ghost ghost removed the in progress label Nov 25, 2018
@ludeeus ludeeus deleted the ruter-offset branch November 25, 2018 11:33
balloob pushed a commit that referenced this pull request Nov 26, 2018
@ludeeus @balloob
Set correct default offset (#18678)
c3b76b4
balloob pushed a commit to home-assistant/home-assistant.io that referenced this pull request Nov 28, 2018
@tjorim @balloob
Default is now 0
c614325 
home-assistant/core#18678
@balloob balloob mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@ludeeus ludeeus

Labels

cherry-picked cla-signed integration: ruter small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.83

Development

Successfully merging this pull request may close these issues.

4 participants

@ludeeus @fabaff @balloob @homeassistant