Skip to content

Create page for bt_smarthub device tracker#6528

Merged
MartinHjelmare merged 7 commits intohome-assistant:nextfrom
jxwolstenholme:next
Oct 29, 2018
Merged

Create page for bt_smarthub device tracker#6528
MartinHjelmare merged 7 commits intohome-assistant:nextfrom
jxwolstenholme:next

Conversation

@jxwolstenholme
Copy link
Copy Markdown
Contributor

Description:

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost added the to-do label Oct 5, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! next This PR goes into the next branch has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed and removed to-do labels Oct 5, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxwolstenholme I've reviewed your PR, and left some comments. Could you please take a look? 👍

footer: true
logo: bt.png
ha_category: Presence Detection
---
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ha_release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ha_iot_class.

host: 192.168.1.254
```

Configuration variables:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration


- **host** (*Optional*): The IP address of your router, Default: 192.168.1.254.

See the [device tracker component page](/components/device_tracker/) for instructions how to configure the people to be tracked.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for instructions how -> for instructions on how

# Example configuration.yaml entry
device_tracker:
- platform: bt_smarthub
host: 192.168.1.254
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Oct 5, 2018
Comment thread source/_components/device_tracker.bt_smarthub.markdown Outdated
frenck
frenck previously approved these changes Oct 5, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 5, 2018

Thanks for updating this PR!

✅ Looks good. Can be merged as soon as the parent PR gets merged in.

Happy Hacktoberfest 🎉

../Frenck

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Oct 5, 2018
Copy link
Copy Markdown
Contributor

@tjorim tjorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR here, @jxwolstenholme, I left some feedback for you.

⚠️ The ha_release will need an update before merging this one in.

Comment thread source/_components/device_tracker.bt_smarthub.markdown Outdated
Comment thread source/_components/device_tracker.bt_smarthub.markdown Outdated
Comment thread source/_components/device_tracker.bt_smarthub.markdown Outdated
Comment thread source/_components/device_tracker.bt_smarthub.markdown Outdated
frenck
frenck previously approved these changes Oct 18, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

footer: true
logo: bt.png
ha_category: Presence Detection
ha_release: "0.80"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.82

footer: true
logo: bt.png
ha_category: Presence Detection
---
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ha_iot_class.

@frenck frenck added parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Oct 25, 2018
@frenck frenck removed the awaits-parent Awaits the merge of an parent PR label Oct 25, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 25, 2018

@jxwolstenholme Could you please update the requested changes by @MartinHjelmare ? 👍

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@MartinHjelmare MartinHjelmare merged commit cb8726b into home-assistant:next Oct 29, 2018
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Oct 29, 2018
zsarnett pushed a commit to zsarnett/home-assistant.io that referenced this pull request Oct 30, 2018
* Create page for bt_smarthub device tracker

* Update device_tracker.bt_smarthub.markdown

* Update device_tracker.bt_smarthub.markdown

* Update device_tracker.bt_smarthub.markdown

* Update device_tracker.bt_smarthub.markdown

* Fix unnecessary blank lines

* Add missing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants