Create page for bt_smarthub device tracker#6528
Create page for bt_smarthub device tracker#6528MartinHjelmare merged 7 commits intohome-assistant:nextfrom
Conversation
frenck
left a comment
There was a problem hiding this comment.
@jxwolstenholme I've reviewed your PR, and left some comments. Could you please take a look? 👍
| footer: true | ||
| logo: bt.png | ||
| ha_category: Presence Detection | ||
| --- |
There was a problem hiding this comment.
Please add ha_iot_class.
| host: 192.168.1.254 | ||
| ``` | ||
|
|
||
| Configuration variables: |
There was a problem hiding this comment.
Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration
|
|
||
| - **host** (*Optional*): The IP address of your router, Default: 192.168.1.254. | ||
|
|
||
| See the [device tracker component page](/components/device_tracker/) for instructions how to configure the people to be tracked. |
There was a problem hiding this comment.
for instructions how -> for instructions on how
| # Example configuration.yaml entry | ||
| device_tracker: | ||
| - platform: bt_smarthub | ||
| host: 192.168.1.254 |
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps a user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
|
Thanks for updating this PR! ✅ Looks good. Can be merged as soon as the parent PR gets merged in. Happy Hacktoberfest 🎉 ../Frenck |
There was a problem hiding this comment.
Nice first PR here, @jxwolstenholme, I left some feedback for you.
ha_release will need an update before merging this one in.
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
ha_release might need an update before merging this one in.
| footer: true | ||
| logo: bt.png | ||
| ha_category: Presence Detection | ||
| ha_release: "0.80" |
| footer: true | ||
| logo: bt.png | ||
| ha_category: Presence Detection | ||
| --- |
There was a problem hiding this comment.
Please add ha_iot_class.
|
@jxwolstenholme Could you please update the requested changes by @MartinHjelmare ? 👍 |
* Create page for bt_smarthub device tracker * Update device_tracker.bt_smarthub.markdown * Update device_tracker.bt_smarthub.markdown * Update device_tracker.bt_smarthub.markdown * Update device_tracker.bt_smarthub.markdown * Fix unnecessary blank lines * Add missing elements
Description:
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.