Add device tracking for the BT Smart Hub router by jxwolstenholme · Pull Request #17158 · home-assistant/core

jxwolstenholme · 2018-10-05T09:12:12Z

Description:

Added support for device tracking for the BT Smart Hub router (UK). Might it be sensible to collect this with the bt_home_hub_5 component in some way - perhaps to share a page on home-assistant.io ?

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6528

Example entry for `configuration.yaml` (if applicable):

# Example configuration.yaml entry
device_tracker:
  - platform: bt_smarthub
    host: 192.168.1.254

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

homeassistant/components/device_tracker/bt_smarthub.py

homeassistant · 2018-10-05T09:56:18Z

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/device_tracker/bt_smarthub.py

homeassistant · 2018-10-05T09:57:03Z

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2018-10-05T09:59:43Z

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/device_tracker/bt_smarthub.py

.coveragerc

homeassistant/components/device_tracker/bt_smarthub.py

MartinHjelmare

Great!

MartinHjelmare · 2018-10-11T10:54:53Z

Can be merged when build passes.

houndci-bot · 2018-10-23T14:04:14Z

homeassistant/components/device_tracker/bt_smarthub.py

+
+import homeassistant.helpers.config_validation as cv
+from homeassistant.components.device_tracker import (DOMAIN, 
+                                                     PLATFORM_SCHEMA, DeviceScanner)


line too long (84 > 79 characters)

houndci-bot · 2018-10-23T14:04:15Z

homeassistant/components/device_tracker/bt_smarthub.py

+import voluptuous as vol
+
+import homeassistant.helpers.config_validation as cv
+from homeassistant.components.device_tracker import (DOMAIN, 


trailing whitespace

jxwolstenholme added 4 commits October 5, 2018 09:35

Support for BT smarthub router device tracking

2aa76e5

Update requirements_all.txt for bt_smarthub device tracker

c4fa797

Added bt_smarthub.py exclusion

e8b7ece

Update .coveragerc

0e276ab

homeassistant added integration: device_tracker core new-platform labels Oct 5, 2018

ghost added the in progress label Oct 5, 2018

houndci-bot reviewed Oct 5, 2018

View reviewed changes

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

Update bt_smarthub.py

d8e55d3

homeassistant added the cla-needed label Oct 5, 2018

houndci-bot reviewed Oct 5, 2018

View reviewed changes

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

Update bt_smarthub.py

b1ac1dd

Update bt_smarthub.py

4672482

homeassistant added cla-signed and removed cla-needed labels Oct 5, 2018

jxwolstenholme added 2 commits October 5, 2018 11:16

Update bt_smarthub.py

7333abc

Fix linting issues

773b83f

houndci-bot reviewed Oct 5, 2018

View reviewed changes

jxwolstenholme added 3 commits October 5, 2018 12:08

Update bt_smarthub.py

0d245e1

Update bt_smarthub.py

8d96008

Update bt_smarthub.py

a61bf8c

houndci-bot reviewed Oct 5, 2018

View reviewed changes

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

Update bt_smarthub.py

e747cad

MartinHjelmare requested changes Oct 7, 2018

View reviewed changes

jxwolstenholme added 2 commits October 8, 2018 18:55

Update bt_smarthub.py

a29b46f

Update bt_smarthub.py

585d25a

MartinHjelmare reviewed Oct 9, 2018

View reviewed changes

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

bachya added the Hacktoberfest label Oct 9, 2018

Update bt_smarthub.py

40b9c19

houndci-bot reviewed Oct 10, 2018

View reviewed changes

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

homeassistant/components/device_tracker/bt_smarthub.py Outdated Show resolved Hide resolved

Update bt_smarthub.py

07e1245

MartinHjelmare reviewed Oct 10, 2018

View reviewed changes

.coveragerc Outdated Show resolved Hide resolved

homeassistant/components/device_tracker/bt_smarthub.py Show resolved Hide resolved

jxwolstenholme added 2 commits October 10, 2018 14:38

Update .coveragerc

c91ec99

Update bt_smarthub.py

644a5cb

MartinHjelmare approved these changes Oct 11, 2018

View reviewed changes

MartinHjelmare changed the title ~~Adding support for device tracking for the BT Smart Hub router~~ Add device tracking for the BT Smart Hub router Oct 11, 2018

Minor changes

2d37649

ghost assigned fabaff Oct 13, 2018

Update bt_smarthub.py

e1d92df

houndci-bot reviewed Oct 23, 2018

View reviewed changes

Update bt_smarthub.py

ee2ca3e

MartinHjelmare approved these changes Oct 23, 2018

View reviewed changes

MartinHjelmare merged commit 7be7a8d into home-assistant:dev Oct 23, 2018

ghost removed the in progress label Oct 23, 2018

balloob mentioned this pull request Nov 9, 2018

0.82 #18335

Merged

home-assistant locked and limited conversation to collaborators Feb 5, 2019

Uh oh!

Conversation

jxwolstenholme commented Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

Uh oh!

homeassistant commented Oct 5, 2018

Uh oh!

Uh oh!

homeassistant commented Oct 5, 2018

Uh oh!

homeassistant commented Oct 5, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Oct 11, 2018

Uh oh!

houndci-bot Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

houndci-bot Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jxwolstenholme commented Oct 5, 2018 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):