Skip to content

Add image support for hangouts notification#6254

Merged
arsaboo merged 2 commits into
home-assistant:nextfrom
quazzie:patch-2
Sep 27, 2018
Merged

Add image support for hangouts notification#6254
arsaboo merged 2 commits into
home-assistant:nextfrom
quazzie:patch-2

Conversation

@quazzie
Copy link
Copy Markdown
Contributor

@quazzie quazzie commented Sep 11, 2018

Description:
Add image support for hangouts notifications

Pull request in home-assistant (if applicable): home-assistant/core#16560

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

Add data attribute with image component.
Can be a path or url.
@ghost ghost added the to-do label Sep 11, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Sep 12, 2018
@quazzie
Copy link
Copy Markdown
Contributor Author

quazzie commented Sep 27, 2018

Matching PR in home assistant got merged, might want to merge this also.

Copy link
Copy Markdown
Contributor

@arsaboo arsaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@arsaboo arsaboo merged commit 2c6f85e into home-assistant:next Sep 27, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Sep 27, 2018
@quazzie quazzie deleted the patch-2 branch September 27, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants