Add image support to hangouts notifications#16560
Merged
Merged
Conversation
Add image support to hangouts notification.
add image support
houndci-bot
reviewed
Sep 11, 2018
2 tasks
houndci-bot
reviewed
Sep 11, 2018
forgot schema
houndci-bot
reviewed
Sep 12, 2018
pvizeli
requested changes
Sep 12, 2018
houndci-bot
reviewed
Sep 12, 2018
houndci-bot
reviewed
Sep 12, 2018
houndci-bot
reviewed
Sep 12, 2018
houndci-bot
reviewed
Sep 12, 2018
pvizeli
reviewed
Sep 13, 2018
houndci-bot
reviewed
Sep 13, 2018
pvizeli
reviewed
Sep 13, 2018
Member
There was a problem hiding this comment.
Instead to try to validate the url use a schematic like other notify platforms like:
{
"photo": [
"file": "...",
"url": "...",
]
}
Or simple:
{
"image_file": "",
"image_url": "",
}
You can self select your style, but don't use this urlparse handling.
Examples:
- https://www.home-assistant.io/components/notify/
- https://www.home-assistant.io/components/notify.telegram/
After that it should be ready to merge.
* change to image_file/url
houndci-bot
reviewed
Sep 14, 2018
Contributor
Author
|
@pvizeli this ok ? |
pvizeli
approved these changes
Sep 25, 2018
Member
|
We should create a helper in future |
Member
|
So this PR added incorrect YAML to services.yaml which caused Home Assistant to not boot at all. Which begs the question, did anyone run this PR @quazzie ? |
Contributor
Author
|
Hmm :( sorry last commit (rename to image_file/_url) was made with github edit as i was away so no that last commit was not run. Stupid mistake, sorry. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds image support to hangouts notification
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6254
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: