Skip to content

Improve deCONZ switch platform documentation #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Aug 13, 2018
Merged

Improve deCONZ switch platform documentation #5986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion source/_components/switch.deconz.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ ha_iot_class: "Local Push"

See the [deCONZ main component](/components/deconz/) for configuration instructions.

The `Entity Id` names will be `switch.device_name`, where `device_name` is defined in deCONZ.
Switches are devices like power plugs and sirens.

Note that devices in the switch platform identify as lights, so there is a manually curated list that defines which "lights" are switches.

The `Entity Id` names will be `switch.device_name`, where `device_name` is defined in deCONZ.
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we refer to entity_id as Entity Idelsewhere in the docs?

Copy link
Copy Markdown
Member Author

@Kane610 Kane610 Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to vary

Copy link
Copy Markdown
Member

@frenck frenck Aug 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest is replacing it with either:

"The entity ID names will"
OR
"The entity_id names will".

I'll guess the latter is more fitting, as it matches the rest of the sentence.

Copy link
Copy Markdown
Member Author

@Kane610 Kane610 Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then for consistencies sake I should do the same thing in all deconz pages.

Is it ok if I do that in a clean up PR?

Copy link
Copy Markdown
Member

@frenck frenck Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess it won't hurt that much now at this moment.
Looking forward to the PR 👍

Copy link
Copy Markdown
Member Author

@Kane610 Kane610 Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have it during this week


#### {% linkable_title Verified supported switches %}

- Innr SP120
Expand Down