Improve deCONZ switch platform documentation#5986
Merged
frenck merged 1 commit intohome-assistant:nextfrom Aug 13, 2018
Kane610:deconz-support-for-sirens
Merged
Improve deCONZ switch platform documentation#5986frenck merged 1 commit intohome-assistant:nextfrom Kane610:deconz-support-for-sirens
frenck merged 1 commit intohome-assistant:nextfrom
Kane610:deconz-support-for-sirens
Conversation
ghost
assigned
3 tasks
frenck
added
new-feature
|
|
||
| Note that devices in the switch platform identify as lights, so there is a manually curated list that defines which "lights" are switches. | ||
|
|
||
| The `Entity Id` names will be `switch.device_name`, where `device_name` is defined in deCONZ. |
Member
There was a problem hiding this comment.
Do we refer to entity_id as Entity Idelsewhere in the docs?
Member
There was a problem hiding this comment.
I would suggest is replacing it with either:
"The entity ID names will"
OR
"The entity_id names will".
I'll guess the latter is more fitting, as it matches the rest of the sentence.
Member
Author
There was a problem hiding this comment.
Then for consistencies sake I should do the same thing in all deconz pages.
Is it ok if I do that in a clean up PR?
Member
There was a problem hiding this comment.
Yeah, I guess it won't hurt that much now at this moment.
Looking forward to the PR 👍
Member
Author
There was a problem hiding this comment.
You'll have it during this week
frenck
approved these changes
Aug 13, 2018
balloob
added
the
cherry-picked
balloob
pushed a commit
that referenced
this pull request
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#15896
Checklist:
current. New documentation for platforms/components and features should go tonext.