-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Add HomeKit support for media players #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,9 +30,16 @@ homekit: | |
| include_domains: | ||
| - alarm_control_panel | ||
| - light | ||
| - media_player | ||
| entity_config: | ||
| alarm_control_panel.home: | ||
| code: 1234 | ||
| media_player.living_room: | ||
| mode: | ||
| - on_off | ||
| - play_pause | ||
| - play_stop | ||
| - toggle_mute | ||
| ``` | ||
|
|
||
| {% configuration %} | ||
|
|
@@ -95,6 +102,11 @@ homekit: | |
| required: false | ||
| type: string | ||
| default: '' | ||
| mode: | ||
| description: Operation mode of switches within HomeKit. Valid modes are `on_off`, `play_pause`, `play_stop`, and `toggle_mute`. The entity will ignore any `mode` which is not supported. If not specified, all supported modes will be added. Only applicable for `media_player` entities. | ||
| required: false | ||
| type: list | ||
| default: `on_off`, `play_pause`, `play_stop`, `toggle_mute` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default would change to: '
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, but I don't think a code block should be used since it's not the actual entry. I prefer just plain text.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wanted to use the same syntax for placeholders as above for |
||
| {% endconfiguration %} | ||
|
|
||
| <p class='note'> | ||
|
|
@@ -229,6 +241,7 @@ The following components are currently supported: | |
| | fan | Fan | Support for `on / off`, `direction` and `oscillating`. | | ||
| | light | Light | Support for `on / off`, `brightness` and `rgb_color`. | | ||
| | lock | DoorLock | Support for `lock / unlock`. | | ||
| | media_player | MediaPlayer | Represented as a series of switches which control `on / off`, `play / pause`, `play / stop`, or `mute` depending on `supported_features` of entity and the `mode` list specified in `entity_config`. | | ||
| | sensor | TemperatureSensor | All sensors that have `Celsius` or `Fahrenheit` as their `unit_of_measurement` or `temperature` as their `device_class`. | | ||
| | sensor | HumiditySensor | All sensors that have `%` as their `unit_of_measurement` and `humidity` as their `device_class`. | | ||
| | sensor | AirQualitySensor | All sensors that have `pm25` as part of their `entity_id` or `pm25` as their `device_class` | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of:
Operation modes of switches within the Home app. Valid modes are
on_off,play_pause,play_stop, andtoggle_mute.The entity will ignore anymodewhich is not supported.If not specified, all supported modes will be added.Only applicable formedia_playerentities.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I think we should stay consistent and use HomeKit rather than the Home app, because HomeKit support is not exclusive to Apple's Home app.