Add HomeKit support for media players#5378
Add HomeKit support for media players#5378cdce8p merged 5 commits intohome-assistant:nextfrom schmittx:homekit-media-player-support
Conversation
cdce8p
added
the
new-feature
| type: string | ||
| default: '' | ||
| mode: | ||
| description: Operation mode of switches within HomeKit. Valid modes are `on_off`, `play_pause`, `play_stop`, and `toggle_mute`. The entity will ignore any `mode` which is not supported. If not specified, all supported modes will be added. Only applicable for `media_player` entities. |
There was a problem hiding this comment.
What do you think of:
Operation modes of switches within the Home app. Valid modes are on_off, play_pause, play_stop, and toggle_mute. The entity will ignore any mode which is not supported.If not specified, all supported modes will be added. Only applicable for media_player entities.
There was a problem hiding this comment.
I agree, but I think we should stay consistent and use HomeKit rather than the Home app, because HomeKit support is not exclusive to Apple's Home app.
| description: Operation mode of switches within HomeKit. Valid modes are `on_off`, `play_pause`, `play_stop`, and `toggle_mute`. The entity will ignore any `mode` which is not supported. If not specified, all supported modes will be added. Only applicable for `media_player` entities. | ||
| required: false | ||
| type: list | ||
| default: `on_off`, `play_pause`, `play_stop`, `toggle_mute` |
There was a problem hiding this comment.
The default would change to: '<All supported modes>'
There was a problem hiding this comment.
I agree, but I don't think a code block should be used since it's not the actual entry. I prefer just plain text.
There was a problem hiding this comment.
I wanted to use the same syntax for placeholders as above for entity_id. A normal string might be misleading.
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Ready to be merged once parent PR is merged and test pass.
2 participants
Description:
Adds support for media players in HomeKit.
Pull request in home-assistant (if applicable): home-assistant/core#14446
Checklist:
current. New documentation for platforms/components and features should go tonext.