Added Time SMA#4926
Merged
Merged
Conversation
3 tasks
frenck
added
the
new-feature
OttoWinter
reviewed
Mar 18, 2018
| @@ -56,14 +59,14 @@ filters: | |||
| type: map | |||
Member
There was a problem hiding this comment.
From previous PR, but this is not really a map, but rather a list.
| footer: true | ||
| ha_category: Sensor | ||
| ha_release: 0.65 | ||
| ha_release: 0.66 |
Member
There was a problem hiding this comment.
I'm not sure, but isn't this variable supposed to say when this was added? I think it's also used in the "Added in ..." sections.
|
|
||
| The paper defines three types/versions of the Simple Moving Average (SMA): *last*, *next* and *linear*. Currently only *last* is implemented. | ||
|
|
||
| Theta, as described in the paper, is the `window_size` parameter, and can be expressed using time notation (e.g., 00:05 for a five minutes time window). |
Member
There was a problem hiding this comment.
When we start adding other types, I think it would be nice to provide a separate configuration.yaml snippet for each filter:, because from the current layout it's quite difficult to find what you're really interested in (especially as a new user). Just a comment and out of scope for this PR of course.
frenck
approved these changes
Mar 18, 2018
Member
|
Corrected most, build passes, parent PR has been merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added Time SMA filter documentation
Pull request in home-assistant (if applicable): home-assistant/core#13104
Checklist:
current. New documentation for platforms/components and features should go tonext.