Skip to content

Allow zero purge_interval to disable recorder purge#4591

Merged
arsaboo merged 2 commits intohome-assistant:nextfrom
amelchio:recorder-zero-interval
Feb 10, 2018
Merged

Allow zero purge_interval to disable recorder purge#4591
arsaboo merged 2 commits intohome-assistant:nextfrom
amelchio:recorder-zero-interval

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

@amelchio amelchio commented Feb 6, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#12220

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

Comment thread source/_components/recorder.markdown Outdated
type: int
purge_interval:
description: How often (in days) the purge task runs. If a scheduled purge is missed (e.g., if Home Assistant was not running), the schedule will resume soon after Home Assistant restarts. You can use the [service](#service-purge) call `purge` when required without impacting the purge schedule.
description: How often (in days) the purge task runs. If a scheduled purge is missed (e.g., if Home Assistant was not running), the schedule will resume soon after Home Assistant restarts. You can use the [service](#service-purge) call `purge` when required without impacting the purge schedule. If this is set to zero, purging is disabled.
Copy link
Copy Markdown
Member

@ludeeus ludeeus Feb 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That field expect an numeric value, wouldn't If this is set to 0, purging is disabled. be more descriptive?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I am not sure, so now I changed it to include both options :)

Copy link
Copy Markdown
Contributor

@arsaboo arsaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥇

@arsaboo arsaboo merged commit 0b68b47 into home-assistant:next Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants