Allow zero purge_interval to disable recorder purge#12220
Merged
balloob merged 1 commit intohome-assistant:devfrom Feb 8, 2018
Merged
Allow zero purge_interval to disable recorder purge#12220balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
2 tasks
balloob
approved these changes
Feb 8, 2018
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This was suggested in #11976 (comment) as an easy way to disable recorder purge, now that purging soon becomes the default.
It turns out that we still have the code to disable purging if
purge_intervalis falsy. It was a leftover from whenpurge_intervalcould beNoneso maybe I subconsciously anticipated this suggestion :)So this PR just includes zero in the allowed range.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4591
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully.