Skip to content

Added documentation for password mode in input_text#4489

Merged
balloob merged 3 commits into
home-assistant:currentfrom
covrig:next
Feb 11, 2018
Merged

Added documentation for password mode in input_text#4489
balloob merged 3 commits into
home-assistant:currentfrom
covrig:next

Conversation

@covrig
Copy link
Copy Markdown
Contributor

@covrig covrig commented Jan 21, 2018

Description:
Added mode: password to input_text documentation.

Pull request in home-assistant (if applicable):
home-assistant/core#11849
home-assistant/frontend#824

Checklist:

  • [ x] Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • [ x] The documentation follow the standards.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 22, 2018

Thanks, @covrig! Can be merged as soon as the parent PR gets merged.

@covrig
Copy link
Copy Markdown
Contributor Author

covrig commented Feb 11, 2018

@balloob @frenck I noticed that home-assistant/core#11849 was merged, but this documentation wasn't.

@balloob balloob changed the base branch from next to current February 11, 2018 17:34
@balloob balloob merged commit 3ce0f09 into home-assistant:current Feb 11, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 11, 2018

Thanks! Merged

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 11, 2018

I didn't merge since there where 2 parent PR referenced in this PR, from which I concluded both where mandatory. Only one of them was merged, so yeah... that is why.

@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 11, 2018

Ah yes, we ended up splitting the frontend PR in 2 and merged the password one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants