Added password mode to input_text (obscure content of text box)#11849
Merged
Conversation
Temperature detection range: -20 - 60 Deg.C ( + / - 0.3 Deg.C ) Humidity detection range: 0 - 100pct RH ( + / - 0.3pct ) Atmospheric pressure detection range: 30 - 110KPa ( + / - 120Pa )
Hide the content of the input_text field
andrey-git
reviewed
Jan 21, 2018
| elif self._data_key == 'pressure' and value == 0: | ||
| return False | ||
| self._state = round(value, 2) | ||
| self._state = round(value, 1) |
Contributor
Author
There was a problem hiding this comment.
Yes the PR was already approved. I completely forgot about it. My apologies.
#11673
balloob
requested changes
Jan 21, 2018
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Please remove the Aqara commit from your PR and add a test for the new mode.
This reverts commit a3124a6.
tinloaf
approved these changes
Jan 23, 2018
Contributor
tinloaf
left a comment
tinloaf
left a comment
There was a problem hiding this comment.
Aside from linting, this looks good to me. The frontend PR should probably be split into two, though. "One change, one PR" makes it easier. ;)
This was referenced Jan 25, 2018
pvizeli
approved these changes
Feb 8, 2018
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Provide an optional way for the user to securely enter a password/text value.
In combination with:
home-assistant/frontend#837
Pull request in home-assistant.github.io with documentation (if applicable):
home-assistant/home-assistant.io#4489
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
Added documentation for password mode in input_text home-assistant.io#4489