Skip to content

Remove 'Name' field from config flow in gios#41588

Merged
c0ffeeca7 merged 2 commits into
home-assistant:nextfrom
mik-laj:patch-9
Dec 16, 2025
Merged

Remove 'Name' field from config flow in gios#41588
c0ffeeca7 merged 2 commits into
home-assistant:nextfrom
mik-laj:patch-9

Conversation

@mik-laj
Copy link
Copy Markdown
Contributor

@mik-laj mik-laj commented Nov 3, 2025

Removed the 'Name' section from the configuration details.

Related PR: home-assistant/core#155741

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copilot AI review requested due to automatic review settings November 3, 2025 16:48
@mik-laj mik-laj requested a review from bieniu as a code owner November 3, 2025 16:48
@home-assistant home-assistant Bot added the current This PR goes into the current branch label Nov 3, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 3, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 72479b5
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/6940494844b60b0008e50660
😎 Deploy Preview https://deploy-preview-41588--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 3, 2025
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Nov 3, 2025

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "Name" configuration field from the GIOS integration documentation. The change aligns the documentation with the standard pattern used by most similar integrations and removes a configuration option that is no longer present or needed in the config flow.

@mik-laj mik-laj changed the base branch from current to next November 3, 2025 16:56
@home-assistant home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch current This PR goes into the current branch labels Nov 3, 2025
@home-assistant home-assistant Bot added the next This PR goes into the next branch label Nov 3, 2025
Removed the 'Name' section from the configuration details.
@mik-laj mik-laj changed the title Remove 'Name' field from gios integration Remove 'Name' field from config flow in gios Nov 3, 2025
@c0ffeeca7
Copy link
Copy Markdown
Contributor

Thank you for contributing, @mik-laj 👍

Please fill out the PR template.

  • add the link to the related core PR next to Link to parent pull request in the codebase:
  • Fill out the corresponding checkboxes
image

@c0ffeeca7 c0ffeeca7 marked this pull request as draft November 4, 2025 05:41
@c0ffeeca7
Copy link
Copy Markdown
Contributor

I'm drafting this PR, as changes are needed.

Please undraft it once the changes have been implemented and the PR is ready for review again.

@home-assistant home-assistant Bot added the parent-merged The parent PR has been merged already label Dec 15, 2025
@bieniu
Copy link
Copy Markdown
Member

bieniu commented Dec 15, 2025

@mik-laj Is PR ready for review?

@mik-laj mik-laj marked this pull request as ready for review December 15, 2025 17:45
@mik-laj
Copy link
Copy Markdown
Contributor Author

mik-laj commented Dec 15, 2025

@bieniu Yes. it is ready for review.

@c0ffeeca7 c0ffeeca7 merged commit 67ef18e into home-assistant:next Dec 16, 2025
7 checks passed
@home-assistant home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Dec 16, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants