Set station name as device name in GIOS#155762
Merged
Merged
Conversation
Contributor
|
Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
mik-laj
force-pushed
the
gios-fix-5
branch
2 times, most recently
from
c05e0af to
1156200
Compare
8 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the user-configurable device name from the GIOS integration config flow and instead uses the station name from the GIOS API. For backward compatibility, existing configurations with a custom name will continue to use it, while new setups will use the station name with translation support.
Key changes:
- Config flow no longer allows users to set custom device names
- Device names are now derived from the station name via API (with translation support for new configs)
- Backward compatibility maintained for existing configs with
CONF_NAMEin their data
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/gios/config_flow.py | Removed CONF_NAME import and name field from config flow schema |
| homeassistant/components/gios/sensor.py | Updated device info creation to use station name with translation support, while maintaining backward compatibility for existing configs with custom names |
| homeassistant/components/gios/strings.json | Added device translation key for station name formatting |
| tests/components/gios/conftest.py | Updated mock config entry to remove CONF_NAME from test data |
| tests/components/gios/test_config_flow.py | Removed CONF_NAME import and from test config data |
| tests/components/gios/test_init.py | Added test for device naming behavior based on config data (with/without CONF_NAME) |
| tests/components/gios/test_sensor.py | Updated entity IDs in tests to reflect new naming based on station name |
| tests/components/gios/snapshots/*.ambr | Updated snapshots to reflect new entity naming scheme |
Comments suppressed due to low confidence (1)
homeassistant/components/gios/sensor.py:18
- The
CONF_NAMEimport is still present but is now only used with.get()method on line 187. Since this is for backward compatibility with existing config entries, the import is actually still needed and should remain. However, it would be clearer to add a comment explaining this is kept for backward compatibility with existing configurations.
from homeassistant.const import CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, CONF_NAME
bieniu
reviewed
Nov 17, 2025
| }, | ||
| "device": { | ||
| "station": { | ||
| "name": "Station {station_name}" |
Member
There was a problem hiding this comment.
TBH I see no reason to add the word "Station" to the device name. Other integrations simply use the name/location of the measurement/weather station.
Contributor
Author
There was a problem hiding this comment.
I removed the prefix.
| else: | ||
| device_info_kwargs["translation_key"] = "station" | ||
| device_info_kwargs["translation_placeholders"] = {"station_name": station_name} | ||
| self._attr_device_info = DeviceInfo(**device_info_kwargs) |
Member
There was a problem hiding this comment.
I would move the creation of device info to the coordinator module:
self.device_info = DeviceInfo(
entry_type=DeviceEntryType.SERVICE,
identifiers={(DOMAIN, str(gios.station_id))},
manufacturer=MANUFACTURER,
name=config_entry.data.get(CONF_NAME) or gios.station_name,
configuration_url=URL.format(station_id=gios.station_id),
)and only add here self._attr_device_info = coordinator.device_info
Contributor
Author
There was a problem hiding this comment.
I moved device info to coordinator.
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
previously requested changes
Nov 23, 2025
bieniu
requested changes
Nov 24, 2025
Member
|
Documentation should be updated 
|
Contributor
Author
Here is PR: home-assistant/home-assistant.io#41588 |
bieniu
reviewed
Nov 24, 2025
Contributor
Author
|
The integration still have 100% coverage. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bieniu
approved these changes
Dec 15, 2025
Member
|
Requested changes have been addressed, I'm dismissing previous reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This change supersedes: #155741
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: