Skip to content

Docs for current and target temp scale/offset.#40770

Merged
c0ffeeca7 merged 4 commits into
home-assistant:nextfrom
illia-piskurov:next
Nov 7, 2025
Merged

Docs for current and target temp scale/offset.#40770
c0ffeeca7 merged 4 commits into
home-assistant:nextfrom
illia-piskurov:next

Conversation

@illia-piskurov
Copy link
Copy Markdown
Contributor

@illia-piskurov illia-piskurov commented Sep 8, 2025

Proposed change

The documentation previously stated that scale and offset only applied to the target temperature.
This was incorrect: in reality they apply to both target and current temperature.

This fix corrects the documentation.

There are devices that require different scaling for target and current temperatures (for example, Cooper air conditioners). People have also reported this limitation on the forum:

https://community.home-assistant.io/t/wth-why-do-modbus-climate-entities-only-have-one-scale-setting-for-temperature-registers/803414

https://community.home-assistant.io/t/modbus-plataform-climate/323571

This was also discussed in PR: home-assistant/core#135848.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch WTH labels Sep 8, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 8, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit d42b84e
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/690d783676cac50008c8d7b8
😎 Deploy Preview https://deploy-preview-40770--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation change is ok, but the PR test seems wrong:

"Now scale and offset is applied to both target and current temperature at the same time"

as far as I can see, scale and offset are applied to target and current temperature on dev, so what have changed in code "now" signals a change, but if the code have not changed then please reword it accordingly.

It is correct that the documentation was incorrect, and it is now corrected.

Once the PR text is updated, ping me as reviewer and I will approve the PR (remembering the code PR is still open).

janiversen
janiversen previously approved these changes Sep 10, 2025
Copy link
Copy Markdown
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

(waits for core PR to be merged).

Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny tweak

Comment thread source/_integrations/modbus.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft September 19, 2025 04:51
@home-assistant
Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot added the parent-merged The parent PR has been merged already label Nov 3, 2025
@illia-piskurov illia-piskurov marked this pull request as ready for review November 4, 2025 09:04
@home-assistant home-assistant Bot requested a review from c0ffeeca7 November 4, 2025 09:04
Comment thread source/_integrations/modbus.markdown Outdated
Comment thread source/_integrations/modbus.markdown Outdated
Comment thread source/_integrations/modbus.markdown Outdated
Comment thread source/_integrations/modbus.markdown Outdated
Comment thread source/_integrations/modbus.markdown Outdated
Copy link
Copy Markdown
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @illia-piskurov and @janiversen 👍

@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) November 7, 2025 04:40
@c0ffeeca7 c0ffeeca7 merged commit 464efc6 into home-assistant:next Nov 7, 2025
7 checks passed
@home-assistant home-assistant Bot removed the parent-merged The parent PR has been merged already label Nov 7, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch WTH

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants