Docs for current and target temp scale/offset.#40770
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
janiversen
left a comment
There was a problem hiding this comment.
The documentation change is ok, but the PR test seems wrong:
"Now scale and offset is applied to both target and current temperature at the same time"
as far as I can see, scale and offset are applied to target and current temperature on dev, so what have changed in code "now" signals a change, but if the code have not changed then please reword it accordingly.
It is correct that the documentation was incorrect, and it is now corrected.
Once the PR text is updated, ping me as reviewer and I will approve the PR (remembering the code PR is still open).
janiversen
left a comment
There was a problem hiding this comment.
LGTM, thanks.
(waits for core PR to be merged).
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c0ffeeca7
left a comment
There was a problem hiding this comment.
Thank you, @illia-piskurov and @janiversen 👍
Proposed change
The documentation previously stated that scale and offset only applied to the target temperature.
This was incorrect: in reality they apply to both target and current temperature.
This fix corrects the documentation.
There are devices that require different scaling for target and current temperatures (for example, Cooper air conditioners). People have also reported this limitation on the forum:
https://community.home-assistant.io/t/wth-why-do-modbus-climate-entities-only-have-one-scale-setting-for-temperature-registers/803414
https://community.home-assistant.io/t/modbus-plataform-climate/323571
This was also discussed in PR: home-assistant/core#135848.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.