Documentation for yamaha_musiccast Component#3295
Merged
Merged
Conversation
8 tasks
frenck
requested changes
Sep 2, 2017
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
@jalmeroth, Thank you for your addition to the documentation! Nevertheless, I've found some minor issues. Could you please take a look at my comments? Thanks in advance!
| --- | ||
| layout: page | ||
| title: "Yamaha MusicCast Receivers" | ||
| description: "Instructions how to integrate Yamaha MusicCast Receivers into Home Assistant." |
Member
There was a problem hiding this comment.
Spelling & Grammar:
Instructions how to->Instructions on how to
|
|
||
| A few notes: | ||
|
|
||
| - Currently, this component supports powering on/off, mute, volume control and source selection. Playback controls, for instance play and stop are available for sources that supports it. |
Member
There was a problem hiding this comment.
Spelling & Grammar:
- Missing comma after
control->volume control, and source selection - Missing comma after
instance->for instance, play and stop - Plural subject:
supports->support
frenck
added
the
new-integration
Contributor
Author
|
@frenck thanks for your feedback! Corrected it. 👍 |
frenck
approved these changes
Sep 2, 2017
Member
|
Thanks for fixing those issue so quickly @jalmeroth! 🥇 |
Member
|
Parent PR is merged, merging this PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#9258