Introducing a media_player component for Yamaha Multicast devices by jalmeroth · Pull Request #9258 · home-assistant/core

jalmeroth · 2017-09-01T21:19:25Z

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3295

Example entry for `configuration.yaml` (if applicable):

media_player:
  - platform: yamaha_musiccast
    name: "Living Room"
    host: 192.168.xxx.xx
    port: 5005

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

homeassistant · 2017-09-01T21:19:27Z

Hello @jalmeroth,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

a4fb64b53a79f68966d4af80fe9304d357bcd832 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

mention-bot · 2017-09-01T21:19:29Z

@jalmeroth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @happyleavesaoc to be potential reviewers.

houndci-bot · 2017-09-01T21:19:32Z

+
+    def set_volume_level(self, volume):
+        """Set volume level, range 0..1."""
+        _LOGGER.debug("Volume level: {} / {}".format(volume, volume * self._volumeMax))


line too long (87 > 79 characters)

houndci-bot · 2017-09-01T21:19:33Z

+            # updateStatus_timer was set before
+            if self._mcDevice.updateStatus_timer:
+                _LOGGER.debug("is_alive: {}".format(self._mcDevice.updateStatus_timer.is_alive()))
+                # can happen if e.g. computer was suspended, while hass was running


line too long (83 > 79 characters)

houndci-bot · 2017-09-01T21:19:33Z

+        else:                                       # call from regular polling
+            # updateStatus_timer was set before
+            if self._mcDevice.updateStatus_timer:
+                _LOGGER.debug("is_alive: {}".format(self._mcDevice.updateStatus_timer.is_alive()))


line too long (98 > 79 characters)

houndci-bot · 2017-09-01T21:19:33Z

+    def update(self):
+        _LOGGER.debug("update: {}".format(self.entity_id))
+
+        if not self.entity_id:                      # call from constructor setup_platform()


line too long (92 > 79 characters)

houndci-bot · 2017-09-01T21:19:33Z

+
+    @property
+    def media_image_url(self):
+        return self._media_status.media_image_url if self._media_status else None


line too long (81 > 79 characters)

houndci-bot · 2017-09-01T21:19:33Z

+
+    @property
+    def media_duration(self):
+        return self._media_status.media_duration if self._media_status else None


line too long (80 > 79 characters)

homeassistant · 2017-09-01T21:28:35Z

Hello @jalmeroth,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

664c25d6571e2f49f635aea332a848655f220c36 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.
a4fb64b53a79f68966d4af80fe9304d357bcd832 - This commit has something that looks like an email address (jan+github@almeroth.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting Author Name and email@address.com for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

This reverts commit 664c25d.

This reverts commit a4fb64b.

homeassistant · 2017-09-01T21:40:49Z

Hi @jalmeroth,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

* Added Geofency device tracker Added Geofency device tracker * fix pylint error * review fixes * merge coroutines

runningman84 · 2017-09-02T20:01:59Z

this pull request also includes geofency support, which is nice but most likely will be rejected unless being in a separate pr.

This reverts commit c240d90.

jalmeroth · 2017-09-02T20:14:43Z

Whoops, thanks for the heads-up @runningman84. Obviously something went wrong with the rebasing.

andrey-git · 2017-09-05T15:16:12Z

+    @property
+    def state(self):
+        """Return the state of the device."""
+        result = None


if self.power == STATE_ON and self.status is not STATE_UNKNOWN: return self.status return self.power

thanks for your comment, @andrey-git. I will commit this change.

andrey-git · 2017-09-05T15:17:17Z

+
+    @property
+    def media_content_type(self):
+        """Return the media content type."""


just return self.media_status

self.media_status is the whole object incl. artist, etc.. But I guess returning MEDIA_TYPE_MUSIC would be sufficient

@andrey-git

Thanks to comments from @andrey-git

andrey-git · 2017-09-05T16:07:55Z

Thanks!

Introducing media_player yamaha_multicast

a4fb64b

homeassistant added new-platform platform: media_player.yamaha_musiccast cla-error labels Sep 1, 2017

balloobbot added the platform label Sep 1, 2017

houndci-bot reviewed Sep 1, 2017

View reviewed changes

Fix pep8_max_line_length

664c25d

homeassistant added the cla-error label Sep 1, 2017

jalmeroth added 3 commits September 1, 2017 23:36

Revert "Fix pep8_max_line_length"

7b79f48

This reverts commit 664c25d.

Revert "Introducing media_player yamaha_multicast"

4f983bb

This reverts commit a4fb64b.

Introducing media_player for Yamaha MultiCast Devices

51b138f

homeassistant added cla-needed cla-signed and removed cla-needed labels Sep 1, 2017

jalmeroth and others added 8 commits September 2, 2017 00:09

Add missing Docstrings

e055a34

Adding Requirements

b72b7cf

Add Geofency device tracker (#9106)

c240d90

* Added Geofency device tracker Added Geofency device tracker * fix pylint error * review fixes * merge coroutines

Version bump

58fda2a

Version bump

e188e0d

D210: No whitespaces allowed surrounding docstring text

d5247cb

Fix linting

2538d7f

Version bump

7d763b2

Revert "Add Geofency device tracker (#9106)"

0b7fdf1

This reverts commit c240d90.

jalmeroth mentioned this pull request Sep 2, 2017

Documentation for yamaha_musiccast Component home-assistant/home-assistant.io#3295

Merged

jalmeroth added 7 commits September 4, 2017 16:09

Fix Invalid method names

e45c4c5

Fix update_status timer

dda3e85

Fix Invalid class name "mcDevice"

57baeba

Fix Access to a protected members

f3d48bf

Introducing source_list setter

036493e

Fix logging

ca17f17

Version bump

b6b6ed4

homeassistant added the cla-signed label Sep 4, 2017

jalmeroth added 2 commits September 4, 2017 18:11

D400: First line should end with a period (not 'e')

9cbcbe7

Removed unnecessary logging

f250f82

balloobbot added the requirement label Sep 4, 2017

andrey-git reviewed Sep 5, 2017

View reviewed changes

Minor changes

c7e34c4

Thanks to comments from @andrey-git

homeassistant added the cla-signed label Sep 5, 2017

andrey-git merged commit e4bb8b0 into home-assistant:dev Sep 5, 2017

balloob mentioned this pull request Sep 7, 2017

0.53 #9327

Merged

home-assistant locked and limited conversation to collaborators Dec 11, 2017

ghost added integration: yamaha_musiccast and removed platform: media_player.yamaha_musiccast labels Mar 21, 2019

Uh oh!

Conversation

jalmeroth commented Sep 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Sep 1, 2017

Uh oh!

mention-bot commented Sep 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

homeassistant commented Sep 1, 2017

Uh oh!

homeassistant commented Sep 1, 2017

Uh oh!

runningman84 commented Sep 2, 2017

Uh oh!

jalmeroth commented Sep 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrey-git commented Sep 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jalmeroth commented Sep 1, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):