Skip to content

Allow specifying custom html urls to load#3260

Merged
balloob merged 2 commits into
nextfrom
andrey-git-patch-2
Aug 27, 2017
Merged

Allow specifying custom html urls to load#3260
balloob merged 2 commits into
nextfrom
andrey-git-patch-2

Conversation

@andrey-git
Copy link
Copy Markdown
Contributor

Description:

Allow specifying custom html urls to load

Pull request in home-assistant (if applicable): home-assistant/core#9150

@mention-bot
Copy link
Copy Markdown

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ludeeus, @fabaff and @LaurensBot to be potential reviewers.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Found some minor spelling & grammar issues.

Could you please take a look @andrey-git?

Thanks in advance!

Comment thread source/_components/frontend.markdown Outdated

## {% linkable_title Loading extra HTML %}

Starting with version 0.53 you can specify extra html files to load:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling & Grammar:

  • The sentence ends with a :, but is not follow by something, it should end with a .
  • html -> HTML

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@frenck
Copy link
Copy Markdown
Member

frenck commented Aug 27, 2017

Thanks, @andrey-git! 🥇

Ready to merge as soon as parent PR is merged.

@balloob balloob merged commit fbbe3e5 into next Aug 27, 2017
@balloob balloob deleted the andrey-git-patch-2 branch August 27, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants