Allow specifying custom html urls to load.#9150
Merged
Merged
Conversation
|
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @JshWright and @fabaff to be potential reviewers. |
balloob
reviewed
Aug 26, 2017
|
|
||
|
|
||
| @bind_hass | ||
| def add_extra_html_urls(hass, urls): |
Member
There was a problem hiding this comment.
Let's just take in 1 url.
I'm actually not too convinced that we need this method just yet. What would be a usecase that we want to programmatically add these?
Contributor
Author
There was a problem hiding this comment.
Changed to take 1 url
Contributor
Author
|
The reason for For example I have a custom component that registers my custom panel and will add this extra url. |
balloob
approved these changes
Aug 27, 2017
This was referenced Sep 4, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allow specifying custom html urls to load.
Proposed release text:
The frontend component now supports loading custom html files when Home Assistant front end starts.
It could be Javascript, CSS or custom Web Components.
Along there was a breaking change in the way Custom UI is used:
custom_ui_state_cardnow specifies the exact element name and not a suffix afterstate-card. So if you hadstate_card_custom_ui: custom-uiin your config, you should change it tostate_card_custom_ui: state-card-custom-uicustom_ui_state_cardno longer makes the html fetch, you should make it separately:Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3260
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass