DoorBird#3147
Conversation
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Some minor missing information but documentation looks good in general 🍪
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Binary Sensor | ||
| ha_release: "0.50" |
There was a problem hiding this comment.
Release will need to be updated before merge. Most likely to 0.52 since 0.51 is rather imminent.
| - platform: doorbird | ||
| monitored_conditions: | ||
| - doorbell | ||
| ``` |
There was a problem hiding this comment.
Definition of configuration variables are missing. Suggest you consult other similar components for examples.
There was a problem hiding this comment.
I removed that config option, so I guess it's fixed!
|
|
||
| ```yaml | ||
| # Example configuration.yaml entry | ||
| camera: |
There was a problem hiding this comment.
Minimize the configuration example and avoid adding in the optional variables. Feel free to have an advanced configuration example also.
|
|
||
| Configuration variables: | ||
|
|
||
| - **last_visitor** (*Optional*): Adds a second camera that shows the last picture taken when someone rang the doorbell. |
| ```yaml | ||
| # Example configuration.yaml entry | ||
| doorbird: | ||
| host: 192.168.2.xx |
There was a problem hiding this comment.
Avoid setting a specific IP as the example to avoid confusion.
|
|
||
| Configuration variables: | ||
|
|
||
| - **host** (*Required*): The LAN IP address of your device. You can find this by going to the [DoorBird Online check](http://www.doorbird.com/checkonline) and entering the information from the paper that was included in the box. |
There was a problem hiding this comment.
Host generally accepts either hostnames or IP addresses. Is this component hard coded to only accept IP addresses?
There was a problem hiding this comment.
No, but DoorBird devices do not have hostnames (that I can tell). I'll include hostname regardless.
The hostname of a DoorBird device is bha- followed by its MAC address with no separators.
| switches: | ||
| - light_on | ||
| - open_door | ||
| ``` |
There was a problem hiding this comment.
Configuration variables are missing.
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Camera | ||
| ha_release: "0.50" |
There was a problem hiding this comment.
Release will need to be updated before merge. Most likely to 0.52 since 0.51 is rather imminent.
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Hub | ||
| ha_release: "0.50" |
There was a problem hiding this comment.
Release will need to be updated before merge. Most likely to 0.52 since 0.51 is rather imminent.
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Switch | ||
| ha_release: "0.50" |
There was a problem hiding this comment.
Release will need to be updated before merge. Most likely to 0.52 since 0.51 is rather imminent.
Landrash
added
the
new-integration
Landrash
left a comment
Landrash
left a comment
There was a problem hiding this comment.
Looks good and can be merged when parent PR is merged.
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Binary Sensor | ||
| ha_release: "0.52" |
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Camera | ||
| ha_release: "0.52" |
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Hub | ||
| ha_release: "0.52" |
| footer: true | ||
| logo: doorbird.png | ||
| ha_category: Switch | ||
| ha_release: "0.52" |
3 participants
Description:
Adds documentation for the new DoorBird components.
Pull request in home-assistant (if applicable): home-assistant/core#9281