DoorBird Component by Klikini · Pull Request #9281 · home-assistant/core

Klikini · 2017-09-03T15:30:50Z

Description:

Adds components for the DoorBird video doorbell.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3147

Example entry for `configuration.yaml` (if applicable):

doorbird:
  host: 192.168.2.16
  username: ghaigb0001
  password: **********

binary_sensor:
  - platform: doorbird
    monitored_conditions:
      - doorbell

camera:
  - platform: doorbird
    last_visitor: true

switch:
  - platform: doorbird
    switches:
      - light_on
      - open_door

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

houndci-bot · 2017-09-03T15:30:57Z

+        """Wait for the correct amount of assumed time to pass."""
+        if self._state and self._assume_off <= datetime.datetime.now():
+            self._state = False
+            self._assume_off = datetime.datetime.min


no newline at end of file

houndci-bot · 2017-09-03T15:30:57Z

+    else:
+        _LOGGER.error("Could not connect to DoorBird at %s: Error %s",
+                      ip, str(status[1]))
+        return False


no newline at end of file

houndci-bot · 2017-09-03T15:30:57Z

+
+    def disable_motion_detection(self):
+        """Network callbacks are not supported by HA yet."""
+        pass


no newline at end of file

houndci-bot · 2017-09-03T15:30:58Z

+    @Throttle(_MIN_UPDATE_INTERVAL)
+    def update(self):
+        """Pull the latest value from the device."""
+        self._state = self._device.doorbell_state()


no newline at end of file

pvizeli · 2017-09-05T09:32:41Z

Fix lint please...

MartinHjelmare · 2017-09-07T07:56:47Z

+        """Initialize a binary sensor on a DoorBird device."""
+        self._device = device
+        self._sensor_type = sensor_type
+        self._state = STATE_UNKNOWN


Init state as None.

MartinHjelmare · 2017-09-07T08:04:52Z

+class DoorBirdCamera(Camera):
+    """The camera on a DoorBird device."""
+
+    def __init__(self, hass, url, name, interval=None):


Don't pass in hass. It will be set on the entity when it has been added to home assistant.

What do I replace the references with to access that? self.hass?

MartinHjelmare · 2017-09-07T08:13:19Z

+
+    add_devices(switches)
+    _LOGGER.info("Added DoorBird switches")
+    return True


Platforms for EntityComponent should not return anything.

MartinHjelmare · 2017-09-07T08:14:14Z

+    """A relay in a DoorBird device."""
+    def __init__(self, device, switch):
+        """Initialize a relay in a DoorBird device."""
+        if switch not in SWITCHES:


You already validate this in the config schema.

MartinHjelmare · 2017-09-07T08:18:27Z

+
+        now = datetime.datetime.now()
+        self._assume_off = now + SWITCHES[self._switch]["time"]
+        return True


MartinHjelmare · 2017-09-07T08:19:36Z

+
+    def turn_off(self, **kwargs):
+        """The relays are time-based and cannot be turned off."""
+        return False


Raise not implemented error.

MartinHjelmare · 2017-09-16T08:45:34Z

+        "icon": {
+            True: "bell-ring",
+            False: "bell",
+            "None": "bell-outline"


Why not map this to None?

I assumed None behaved like null and would cause problems. I guess not!

MartinHjelmare · 2017-09-16T08:51:01Z

+        """Get the name of the camera."""
+        return self._name
+
+    def camera_image(self):


Remove this. Since you implement the async version you don't need the sync version.

MartinHjelmare · 2017-09-16T08:56:19Z

+
+    def enable_motion_detection(self):
+        """Network callbacks are not supported by HA yet."""
+        pass


Don't overwrite if you don't support it.

MartinHjelmare · 2017-09-16T08:56:27Z

+
+    def disable_motion_detection(self):
+        """Network callbacks are not supported by HA yet."""
+        pass


Don't overwrite if you don't support it.

MartinHjelmare · 2017-09-16T08:58:39Z

+import async_timeout
+
+from homeassistant.components.camera import PLATFORM_SCHEMA, Camera
+from homeassistant.components.doorbird import DOMAIN


Fix. See above.

MartinHjelmare · 2017-09-16T09:03:57Z

+    switches = []
+    for switch in SWITCHES:
+        if switch in config.get(CONF_SWITCHES):
+            _LOGGER.debug("Adding DoorBird switch " +


_LOGGER.debug("Adding DoorBird switch %s", SWITCHES[switch]["name"])

MartinHjelmare · 2017-09-16T09:05:15Z

+                               _LIVE_INTERVAL)]
+
+    if config.get(CONF_SHOW_LAST_VISITOR):
+        _LOGGER.debug("Adding DoorBird camera " + _CAMERA_LAST_VISITOR)


_LOGGER.debug("Adding DoorBird camera %s", _CAMERA_LAST_VISITOR)

MartinHjelmare · 2017-09-16T09:05:42Z

+    """Set up the DoorBird camera platform."""
+    device = hass.data.get(DOMAIN)
+
+    _LOGGER.debug("Adding DoorBird camera " + _CAMERA_LIVE)


_LOGGER.debug("Adding DoorBird camera %s", _CAMERA_LIVE)

MartinHjelmare · 2017-09-16T09:07:19Z

+        self._device = device
+        self._sensor_type = sensor_type
+        self._state = None
+        super(DoorBirdBinarySensor, self).__init__()


Remove. There's no init methods in the parent classes.

MartinHjelmare · 2017-09-16T09:08:29Z

+
+    async_add_devices(entities)
+    _LOGGER.info("Added DoorBird camera(s)")
+    return True


houndci-bot · 2017-09-17T14:27:06Z

'homeassistant.util.async.run_coroutine_threadsafe' imported but unused

MartinHjelmare

One fix and this should be good to go.

MartinHjelmare · 2017-09-17T16:41:37Z

+    """Set up the DoorBird binary sensor component."""
+    device = hass.data.get(DOORBIRD_DOMAIN)
+    add_devices([DoorBirdBinarySensor(device, "doorbell")], True)
+    return True


Remove. Sorry I missed it before.

MartinHjelmare

Nice!

DoorBird Component

80fa29c

homeassistant added integration: doorbird new-platform platform: binary_sensor.doorbird cla-signed labels Sep 3, 2017

balloobbot added component platform requirement labels Sep 3, 2017

houndci-bot reviewed Sep 3, 2017

View reviewed changes

This was referenced Sep 3, 2017

DoorBird #8871

Closed

DoorBird home-assistant/home-assistant.io#3147

Merged

homeassistant added the cla-signed label Sep 3, 2017

add newlines at end of files

db3bd1a

MartinHjelmare requested changes Sep 7, 2017

View reviewed changes

Andy Castille added 2 commits September 14, 2017 17:13

fix lint

b2f2c9d

fix doorbird components conventions

991b63e

MartinHjelmare requested changes Sep 16, 2017

View reviewed changes

houndci-bot reviewed Sep 17, 2017

View reviewed changes

fix doorbird domain import and log strings

4abe294

homeassistant added the cla-signed label Sep 17, 2017

don't redundantly add switches

6dcb009

MartinHjelmare requested changes Sep 17, 2017

View reviewed changes

Remove return statement from setup_platform

d4736af

MartinHjelmare approved these changes Sep 17, 2017

View reviewed changes

MartinHjelmare merged commit 5f24cc2 into home-assistant:dev Sep 17, 2017

balloob mentioned this pull request Sep 22, 2017

0.54 #9532

Merged

home-assistant locked and limited conversation to collaborators Mar 3, 2018

ghost removed platform: binary_sensor.doorbird labels Mar 21, 2019

Uh oh!

Conversation

Klikini commented Sep 3, 2017

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvizeli commented Sep 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Example entry for `configuration.yaml` (if applicable):