Skip to content

add device arguments for group commands#2732

Merged
fabaff merged 3 commits into
home-assistant:nextfrom
aequitas:group_commands
Jul 6, 2017
Merged

add device arguments for group commands#2732
fabaff merged 3 commits into
home-assistant:nextfrom
aequitas:group_commands

Conversation

@aequitas
Copy link
Copy Markdown
Contributor

@aequitas aequitas commented Jun 1, 2017

Description:
Title says it all, closes: #2707

Pull request in home-assistant (if applicable): home-assistant/core#7577

@mention-bot
Copy link
Copy Markdown

@aequitas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @genestealer, @martinfrancois and @fabaff to be potential reviewers.

Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word aliasses
aliasses -> aliases

Needs to be changed in code and documentation if configuration variables contain the same error.

- **fire_event** (*Optional*): Fire an `button_pressed` event if this device is turned on or off (default: False).
- **signal_repetitions** (*Optional*): Repeat every RFLink command this number of times (default: 1)
- **group** (*Optional*): Allow switch to respond to group commands (ALLON/ALLOFF). (default: yes)
- **group_aliasses** (*Optional*): `aliasses` which only respond to group commands.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word aliasses
aliasses -> aliases

- **signal_repetitions** (*Optional*): Repeat every RFLink command this number of times (default: 1)
- **group** (*Optional*): Allow switch to respond to group commands (ALLON/ALLOFF). (default: yes)
- **group_aliasses** (*Optional*): `aliasses` which only respond to group commands.
- **no_group_aliasses** (*Optional*): `aliasses` which do not respond to group commands.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word aliasses
aliasses -> aliases

- **signal_repetitions** (*Optional*): Set default `signal_repetitions` for RFLink switch devices (see below).

- **group** (*Optional*): Allow light to respond to group commands (ALLON/ALLOFF). (default: yes)
- **group_aliasses** (*Optional*): `aliasses` which only respond to group commands.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word aliasses
aliasses -> aliases


- **group** (*Optional*): Allow light to respond to group commands (ALLON/ALLOFF). (default: yes)
- **group_aliasses** (*Optional*): `aliasses` which only respond to group commands.
- **no_group_aliasses** (*Optional*): `aliasses` which do not respond to group commands.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled word aliasses
aliasses -> aliases

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jul 4, 2017
@aequitas
Copy link
Copy Markdown
Contributor Author

aequitas commented Jul 4, 2017

Corrected spelling, will update sources as well and deprecate incorrect spelled parameters.

Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after parent PR is merged.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff added Fix/Formatting/Language/Spelling and removed new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Jul 6, 2017
@fabaff fabaff merged commit e97d072 into home-assistant:next Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rflink group aliases documentation

4 participants