Correct spelling of aliases, deprecate old config options.#8348
Merged
Conversation
houndci-bot
reviewed
Jul 4, 2017
| from homeassistant.const import ( | ||
| ATTR_UNIT_OF_MEASUREMENT, CONF_NAME, CONF_PLATFORM, | ||
| CONF_UNIT_OF_MEASUREMENT) | ||
| from homeassistant.helpers.deprecation import get_deprecated |
There was a problem hiding this comment.
'homeassistant.helpers.deprecation.get_deprecated' imported but unused
| """Turn the device off.""" | ||
| return self._async_handle_command("turn_off") | ||
|
|
||
| DEPRECATED_CONFIG_OPTIONS = [ |
There was a problem hiding this comment.
expected 2 blank lines after class or function definition, found 1
fabaff
reviewed
Jul 6, 2017
| import logging | ||
|
|
||
| import async_timeout | ||
| import voluptuous as vol |
fabaff
approved these changes
Jul 6, 2017
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
Beside the import ordering looks good to me 🐦
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…stant#8348) * correct spelling of aliases * add deprecation * Fix style.
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
home-assistant/home-assistant.io#2732