Skip to content

Added RTSP documentation to Amcrest camera#2654

Merged
Landrash merged 2 commits into
home-assistant:nextfrom
tchellomello:amcrest_ffmpeg
May 18, 2017
Merged

Added RTSP documentation to Amcrest camera#2654
Landrash merged 2 commits into
home-assistant:nextfrom
tchellomello:amcrest_ffmpeg

Conversation

@tchellomello
Copy link
Copy Markdown
Contributor

Description:

Added RTSP documentation to Amcrest camera.

#cameras.yaml
- platform: amcrest
  name: "Amcrest Backyard"
  host: !secret amcrest_backyard_host
  username: !secret amcrest_backyard_username
  password: !secret amcrest_backyard_password
  port: 80
  resolution: low
  stream_source: rtsp

- platform: amcrest
  name: "Amcrest Driveway"
  host: !secret amcrest_driveway_host
  username: !secret amcrest_driveway_username
  password: !secret amcrest_driveway_password
  port: 80
  resolution: high
  stream_source: rtsp

Pull request in home-assistant (if applicable): home-assistant/core#7646

@mention-bot
Copy link
Copy Markdown

@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff and @colinodell to be potential reviewers.

Copy link
Copy Markdown
Contributor

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after parent PR is merged.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 18, 2017
@Landrash Landrash merged commit 4126a67 into home-assistant:next May 18, 2017
@tchellomello tchellomello deleted the amcrest_ffmpeg branch May 18, 2017 08:14
fabaff pushed a commit that referenced this pull request May 20, 2017
* Added RTSP documentation to Amcrest camera

* Removed ffmpeg_binary since this option is now inherited from ffmpeg root component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants