Skip to content

Added support to Amcrest camera to feed using RTSP via ffmpeg#7646

Merged
pvizeli merged 6 commits into
home-assistant:devfrom
tchellomello:amcrest_ffmpeg
May 18, 2017
Merged

Added support to Amcrest camera to feed using RTSP via ffmpeg#7646
pvizeli merged 6 commits into
home-assistant:devfrom
tchellomello:amcrest_ffmpeg

Conversation

@tchellomello
Copy link
Copy Markdown
Contributor

@tchellomello tchellomello commented May 18, 2017

Description:

Added support to Amcrest camera to feed using RTSP via ffmpeg.
This patch is also an alternative to aiohttp not supporting HTTPDigest authentication.

Of course is expected the ffmpeg to be installed on the system. Documentation will be updated pointing to https://home-assistant.io/components/ffmpeg/ install as pre-requisite.

Related issue (if applicable): fixes #6884 #7398

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2654

Example entry for configuration.yaml (if applicable):

#cameras.yaml
- platform: amcrest
  name: "Amcrest Backyard"
  host: !secret amcrest_backyard_host
  username: !secret amcrest_backyard_username
  password: !secret amcrest_backyard_password
  port: 80
  resolution: low
  stream_source: rtsp

- platform: amcrest
  name: "Amcrest Driveway"
  host: !secret amcrest_driveway_host
  username: !secret amcrest_driveway_username
  password: !secret amcrest_driveway_password
  port: 80
  resolution: high
  stream_source: rtsp

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Many thanks to @pvizeli on explaining how ha-ffmpeg works.

@mention-bot
Copy link
Copy Markdown

@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrey-git, @fabaff and @balloob to be potential reviewers.

@pvizeli pvizeli merged commit 0fd415d into home-assistant:dev May 18, 2017
@tchellomello tchellomello deleted the amcrest_ffmpeg branch May 18, 2017 08:07
This was referenced May 18, 2017
@fabaff fabaff added this to the 0.45 milestone May 20, 2017
fabaff pushed a commit that referenced this pull request May 20, 2017
* Implemented ffmpeg option on Amcrest camera and upgraded to version 1.2.0

* Added ffmpeg arguments and binary options to Amcrest camera

* Added ffmpeg as dependencies

* Makes lint happy and fixed requirements_all.txt

* Inherent the ffmpeg.binary configuration from ffmpeg component

* Update amcrest.py
@balloob balloob mentioned this pull request Jun 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amcrest Camera component streaming only works with aiohttp==1.2

6 participants