Added support to Amcrest camera to feed using RTSP via ffmpeg#7646
Merged
Conversation
|
@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andrey-git, @fabaff and @balloob to be potential reviewers. |
pvizeli
approved these changes
May 18, 2017
This was referenced May 18, 2017
Merged
fabaff
pushed a commit
that referenced
this pull request
May 20, 2017
* Implemented ffmpeg option on Amcrest camera and upgraded to version 1.2.0 * Added ffmpeg arguments and binary options to Amcrest camera * Added ffmpeg as dependencies * Makes lint happy and fixed requirements_all.txt * Inherent the ffmpeg.binary configuration from ffmpeg component * Update amcrest.py
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added support to Amcrest camera to feed using RTSP via ffmpeg.
This patch is also an alternative to
aiohttpnot supportingHTTPDigestauthentication.Of course is expected the
ffmpegto be installed on the system. Documentation will be updated pointing to https://home-assistant.io/components/ffmpeg/ install as pre-requisite.Related issue (if applicable): fixes #6884 #7398
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2654
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.Many thanks to @pvizeli on explaining how
ha-ffmpegworks.