Skip to content

Add scene.delete service for dynamically created scenes (with scene.create)#26504

Merged
MartinHjelmare merged 4 commits into
home-assistant:nextfrom
tetele:scene-delete
Nov 25, 2023
Merged

Add scene.delete service for dynamically created scenes (with scene.create)#26504
MartinHjelmare merged 4 commits into
home-assistant:nextfrom
tetele:scene-delete

Conversation

@tetele
Copy link
Copy Markdown
Contributor

@tetele tetele commented Mar 8, 2023

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 8, 2023
This was referenced Mar 8, 2023
Merged
Closed
@tetele tetele marked this pull request as ready for review March 8, 2023 23:45
@tetele tetele requested a review from a team as a code owner March 8, 2023 23:45
frenck
frenck reviewed Mar 9, 2023
View reviewed changes
Comment thread source/_integrations/scene.markdown Outdated
frenck
frenck previously approved these changes Mar 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 9, 2023
@tetele
Copy link
Copy Markdown
Contributor Author

tetele commented Mar 9, 2023

Thank you very much!

@tetele tetele changed the title Add scene.delete service for dynamically created scenes (with scene.create) Add homeassistant.delete_scene service for dynamically created scenes (with scene.create) Nov 23, 2023
@tetele
Revert "Update docs to match changes upstream"
77f3915 
This reverts commit 502c4f8.
The reason is the reversal of the upstream functionality
home-assistant/core@7f01080
@tetele tetele changed the title Add homeassistant.delete_scene service for dynamically created scenes (with scene.create) Add scene.delete service for dynamically created scenes (with scene.create) Nov 24, 2023
MartinHjelmare
MartinHjelmare approved these changes Nov 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 1d77078 into home-assistant:next Nov 25, 2023
@home-assistant home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Nov 25, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@frenck frenck frenck left review comments

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Documentation PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tetele @frenck @MartinHjelmare