Skip to content

Added scene.delete service#26444

Closed
tetele wants to merge 0 commit into
home-assistant:nextfrom
tetele:patch-1
Closed

Added scene.delete service#26444
tetele wants to merge 0 commit into
home-assistant:nextfrom
tetele:patch-1

Conversation

@tetele
Copy link
Copy Markdown
Contributor

@tetele tetele commented Mar 3, 2023

See home-assistant/core#89090

Proposed change

Add a new scene.delete service that deletes temporary scenes created with the scene.create service.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 3, 2023
@tetele tetele marked this pull request as ready for review March 8, 2023 15:16
@tetele tetele requested review from a team, bdraco, epenet, fabaff and zxdavb as code owners March 8, 2023 15:16
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated commits in this PR, probably caused by basing your feature branch on the current branch instead of the next branch. Please git rebase your changes onto the upstream next branch to clean it up.

Thanks 👍

../Frenck

@home-assistant home-assistant Bot marked this pull request as draft March 8, 2023 21:54
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Mar 8, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tetele
Copy link
Copy Markdown
Contributor Author

tetele commented Mar 8, 2023

Sorry about that. I tried using web tools exclusively (edit button in documentation page and the merge feature in Github) and this is what happened. I should have properly forked the repo.

Hopefully all is fine now.

@tetele tetele marked this pull request as ready for review March 8, 2023 23:17
@home-assistant home-assistant Bot requested a review from frenck March 8, 2023 23:17
@tetele tetele marked this pull request as draft March 8, 2023 23:21
@tetele tetele closed this Mar 8, 2023
@tetele
Copy link
Copy Markdown
Contributor Author

tetele commented Mar 8, 2023

Appologies, I've messed up the rebase so badly that I had to do another PR #26504

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants