Skip to content

Add climate devices documentation for LIVISI integration#25957

Merged
frenck merged 4 commits into
home-assistant:nextfrom
StefanIacobLivisi:livisi-climate
Mar 3, 2023
Merged

Add climate devices documentation for LIVISI integration#25957
frenck merged 4 commits into
home-assistant:nextfrom
StefanIacobLivisi:livisi-climate

Conversation

@StefanIacobLivisi
Copy link
Copy Markdown
Contributor

@StefanIacobLivisi StefanIacobLivisi commented Jan 26, 2023

Proposed change

Add documentation for LIVISI climate devices.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jan 26, 2023
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 26, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jan 26, 2023
@StefanIacobLivisi
Copy link
Copy Markdown
Contributor Author

Hello @frenck , the parent pull request was merged: home-assistant/core#86691 . Do you know if this pull request can also be merged?

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 27, 2023

@StefanIacobLivisi Please don't ping. See also:
https://developers.home-assistant.io/docs/review-process#what-not-to-do

Just have patience.

@frenck frenck added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Feb 27, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @StefanIacobLivisi 👍

@frenck frenck merged commit 798353e into home-assistant:next Mar 3, 2023
@home-assistant home-assistant Bot removed the parent-merged The parent PR has been merged already label Mar 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants